Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Calendar connector: Update Event form values not overriding the values coming in through flow #3887

Closed
jstastny-cz opened this issue Oct 17, 2018 · 6 comments
Assignees
Labels
cat/bug A bug which needs fixing closed/migrated group/connector Supported camel connectors prio/p2 The priority of a bug. p1 means low source/qe Raised by QE status/never-stale Marker that this issue should not be marked as stale

Comments

@jstastny-cz
Copy link

jstastny-cz commented Oct 17, 2018

See also https://issues.jboss.org/browse/ENTESB-11441

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

When using an Update Event step in combination with an incoming Event instance (resulting from Get by id, or Get events actions) the values from the Update Event form are not being set.

The only way to achieve that is placing a Data Mapper before the Update Event step and map fields only partially (those that I don't want to update) and then in 'Update Event' form I can specify the values to update. (Or set the values as constants in data mapper, which I think is even worse option.)

To rephrase a bit, if I specify both mapping and form value, then form value is ignored. When considering the following simple scenario this can be surprising to user. (As they have explicitly set the values to the form.)

Scenario:
I'd like to be also able to send the event through the flow with/without a data mapper, just chaining actions 'Get a specific Event' -> 'Update Event', where the form of update step would have the overriding values specified.

In more complex scenarios, where I want to dynamically set all the values of event, this is not an issue, as data mapper works as expected.

@jstastny-cz jstastny-cz added cat/bug A bug which needs fixing group/connector Supported camel connectors prio/p2 The priority of a bug. p1 means low source/qe Raised by QE labels Oct 17, 2018
@oscerd oscerd self-assigned this Oct 17, 2018
@oscerd
Copy link
Collaborator

oscerd commented Oct 17, 2018

Don't you think this is a feature request?

@jstastny-cz
Copy link
Author

jstastny-cz commented Oct 17, 2018

I hesitated for a while, deciding between bug and feature request. Only the level of surprise caused by this limitation made me call this a bug. It might really be only a usability issue, if we're tracking such things.

@oscerd
Copy link
Collaborator

oscerd commented Oct 17, 2018

In my opinion this can be documented to be sure to avoid surprising reaction. But this is up to to triage call. I'll work on the PATCH action for 7.3, so we can use that to override existing field, without mapping or with mapping.

@stale
Copy link

stale bot commented Jan 15, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Jan 15, 2019
@stale stale bot closed this as completed Jan 22, 2019
@oscerd oscerd reopened this Jan 22, 2019
@stale stale bot removed the status/stale Issue considered to be stale so that it can be closed soon label Jan 22, 2019
@stale
Copy link

stale bot commented Apr 22, 2019

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Apr 22, 2019
@stale stale bot closed this as completed Apr 29, 2019
@tplevko tplevko reopened this Apr 30, 2019
@stale stale bot removed the status/stale Issue considered to be stale so that it can be closed soon label Apr 30, 2019
@tplevko tplevko added the status/never-stale Marker that this issue should not be marked as stale label Apr 30, 2019
@heiko-braun
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug A bug which needs fixing closed/migrated group/connector Supported camel connectors prio/p2 The priority of a bug. p1 means low source/qe Raised by QE status/never-stale Marker that this issue should not be marked as stale
Projects
None yet
Development

No branches or pull requests

4 participants