-
Notifications
You must be signed in to change notification settings - Fork 205
Label color improvements #3906
Comments
I've been feeling the initial grouping qualifier on our labels a bit over-engineered to be honest. So consistent label colors and pulling the grouping out of the text of the label might be much better. |
And see, lookit, this issue has I rest my case. |
One other thought, the |
@gashcrumb |
wrt regarding stripping the prefix: I'm using some tooling which is not colour aware so it would be super awesome if we could keep that. |
Yep, that's cool, I'm fine with that. |
One related question - Is it possible to have the bot automatically tag syndesisio/uxd when a label group/uxd or notif/uxd is applied? |
That'd be a good case for any of the |
What's the difference between pure-bot and syndesis-bot? Also, would it be possible to have a bot automatically add an issue to a project based on a certain label? e.g. with the label notif/uxd, add the issue to https://github.com/syndesisio/syndesis/projects/2 |
I think we should remove |
Yes, that should be possible. Please feel free to open an issue over there at https://github.com/syndesisio/pure-bot |
I wanted features to be green and bugs red. Along these color changes my proposal would be to call it ‘feature’ and ‘bug’ and leave the remaining ‘cat/*’ as is. |
I agree with stans comment about notif |
To add some background info, this is what inspired that changes: The actual categories and colors are less important. what matters is the use of consistent color per category. The part that resonated with me was the red/green/blue separation for bugs/features/enhancements. (Taken from https://robinpowered.com/blog/best-practice-system-for-organizing-and-tagging-github-issues/) |
@heiko-braun But why has every For the case of multiple possible labels I'd like a differentiation in the colour (and if its only a shade) so that ideally every label attached to an issue has different colours (also a good litmus test to check whether labelling was applied correctly: If two labels with the same colours are applied, then a supposed to be single selection was applied twice, like adding |
What do you all think about Roland's proposal ^^? @syndesisio/uxd Also, just open this issue for the bot to automatically notify uxd. @rhuss @heiko-braun |
@dongniwang As long as we triage the "notify/uxd"-labeled items and treat them the way we've been treating group/uxd items, I agree that we don't need the nuanced differentiation and potential confusion of keeping both. |
To put the label "group/uxd" in a historical context, that label was meant at the time to be applied to issues and PRs which result in a UXD document stored within the syndesis repo. AFAIK, UXD artefacts are not stored anymore in the syndesis mono repo, so it would make sense to remove the "group/uxd" label. |
@rhuss - this is probably really nit-picky, but I was wondering if we can increase the color contrast of the notif label set. The current color combination of purple background and black text makes it really hard to scan... |
@dongniwang if it helps you should also have permissions to update 'em -> https://github.com/syndesisio/syndesis/labels I agree, the purple is a bit dark. |
Yeah, I think the labels should please those who are working with them mostly. best negotiate with @heiko-braun but I think increasing the contrast makes sense for sure. |
@dongniwang let's iterate on this. I have changed it to use a white font colour - better? |
I was thinking about making bug and feature top level items, i.e turning them into |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
This is a...
Actually, the label colours have been consolidated to less colours, which is a good thing imo.
However, I think it goes a bit over the top for label groups which are supposed to be allowed multiple times (like
group/
ornotif/
)So my suggestion is:
prio/
,size/
, ...). Not sure whycat/feature
is different from the scheme.cat/
,group/
, especiallynotif/
which targets different teams and its hard to depict from the colour to which team it belongs). For those I suggest to use different but similar colours (e.g. shades of green) and fornotif/
totally separate colours.The text was updated successfully, but these errors were encountered: