Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger based storage for activity monitoring #4011

Closed
zregvart opened this issue Nov 1, 2018 · 11 comments
Closed

Jaeger based storage for activity monitoring #4011

zregvart opened this issue Nov 1, 2018 · 11 comments
Assignees
Labels
cat/techdebt Label for issues identifying technical debt closed/migrated Epic Use by ZenHub, typically also for user stories group/server REST backend for managing integrations prio/p1 The priority of a bug. p1 means high target/7.5 zenhub/review
Milestone

Comments

@zregvart
Copy link
Member

zregvart commented Nov 1, 2018

See also https://issues.jboss.org/browse/ENTESB-11516

This is a...


[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

Description

As discussed in #3922 (and #3337, #3252, #2598, #1780, ...) we need a new mechanism for storing activity entries.

@zregvart zregvart added cat/techdebt Label for issues identifying technical debt group/server REST backend for managing integrations labels Nov 1, 2018
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Nov 1, 2018
@heiko-braun heiko-braun added Epic Use by ZenHub, typically also for user stories prio/p1 The priority of a bug. p1 means high labels Nov 3, 2018
@heiko-braun heiko-braun added this to the Sprint 38 (out-of-band) milestone Dec 3, 2018
@heiko-braun
Copy link
Collaborator

If we move to jaeger, there seem to be ongoing work around badger storage: jaegertracing/jaeger#760

@heiko-braun
Copy link
Collaborator

@chirino Do you still plan to work on this?

@heiko-braun heiko-braun removed this from the Sprint 41 (2/4) milestone Feb 18, 2019
@heiko-braun heiko-braun removed the notif/triage The issue needs triage. Applied automatically to all new issues. label Feb 28, 2019
@heiko-braun heiko-braun added this to the Sprint 46 (2/4) milestone May 6, 2019
@chirino
Copy link
Collaborator

chirino commented May 6, 2019

Current status
The following PRs have been merged to master:
#5280 Add jaeger-spring-boot-starter and enabled it in the syndesis server so it can participate in opentracing requests.
#5283 Add optional jaeger tracing for activity monitoring for the SB runtime.
#5285 Add a jaeger based ActivityTrackingService.

Still Pending:
Being able to optionally enable via syndesis CRD option the jaeger based activity tracing. I started a branch to do that at: https://github.com/chirino/syndesis/tree/jaeger-4
But it does not yet optionally install it.

@chirino
Copy link
Collaborator

chirino commented May 6, 2019

It might be worth waiting until openshift template based installed don't need to be supported anymore so that we can have a more dynamic operator.

@heiko-braun heiko-braun removed this from the Sprint 46 (2/4) milestone May 28, 2019
@heiko-braun heiko-braun added this to the Sprint 50 (1/4) milestone Jul 29, 2019
@chirino
Copy link
Collaborator

chirino commented Aug 22, 2019

This is now completed:

  1. Install syndesis as usual.
  2. Install the Jaeger operator as described at: https://www.jaegertracing.io/docs/1.13/operator/#installing-the-operator-on-okd-openshift
  3. As a cluster admin, grant the sydnesis operator access to create a jaeger instance:
NAMESPACE=`oc project -q`
oc create  rolebinding syndesis-jaeger-operator --clusterrole=jaeger-operator --serviceaccount $NAMESPACE:syndesis-operator
  1. Update the sydnesis custom resource to enable the jaeger addon:
    oc patch syndesis app --type merge -p '{"spec":{"addons":{"jaeger":{"enabled":"true"}}}}'

@heiko-braun
Copy link
Collaborator

Do we fallback to the current activity logging when jaeger is not enabled?

@chirino
Copy link
Collaborator

chirino commented Aug 22, 2019

No. If you enable the jaeger addon, the system will be configured for jaeger

@chirino
Copy link
Collaborator

chirino commented Aug 22, 2019

We also need to do some work to also enable this feature to work when camel-k mode is enabled. Not sure if camel-k support is a must have or not.

@heiko-braun
Copy link
Collaborator

Yes, but what if jaeger is not enabled?

@chirino
Copy link
Collaborator

chirino commented Aug 22, 2019

if you don't enable the jaeger addon, then syndesis continues to use db based activity logging.

@chirino chirino changed the title Alternative storage implementation for activity logging Jaeger based storage for activity monitoring Aug 22, 2019
@heiko-braun
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/techdebt Label for issues identifying technical debt closed/migrated Epic Use by ZenHub, typically also for user stories group/server REST backend for managing integrations prio/p1 The priority of a bug. p1 means high target/7.5 zenhub/review
Projects
None yet
Development

No branches or pull requests

3 participants