Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datamapper] data mapper is not loaded correctly on chrome #6051

Closed
mcada opened this issue Jul 3, 2019 · 15 comments
Closed

[datamapper] data mapper is not loaded correctly on chrome #6051

mcada opened this issue Jul 3, 2019 · 15 comments
Assignees
@igarashitm @riccardo-forina
Labels
cat/bug A bug which needs fixing closed/migrated prio/p2 The priority of a bug. p1 means low source/qe Raised by QE zenhub/backlog

Comments

@mcada
Copy link
Contributor

mcada commented Jul 3, 2019

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

I have seen similar issues raised but they were all solved by something else yet this issue is still present on chrome browser:

screenshot_20190703_104702

The integration is: Database (select * from contact) -> mapper -> Todo connection (create task)

Todo connection was taken from here and created via customizations -> upload swagger specification.

This issue is blocking some of QE automated tests.
@mcada mcada added prio/p0 The priority of a bug. p0 means blocking source/qe Raised by QE labels Jul 3, 2019
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Jul 3, 2019
@mcada
Copy link
Contributor Author

mcada commented Jul 3, 2019

Ok so I just tried it with database(select) -> mapper -> database(insert) and the issue is present, no todo connection required.

@heiko-braun
Copy link
Collaborator

@riccardo-forina @igarashitm Mind to take a look? I remeber there was an AtlasMap version update yesterday I think ...

@heiko-braun heiko-braun added this to the Sprint 48 (4/4) milestone Jul 3, 2019
@riccardo-forina
Copy link
Collaborator

Ok so I just tried it with database(select) -> mapper -> database(insert) and the issue is present, no todo connection required.

What was your insert query?

@riccardo-forina
Copy link
Collaborator

riccardo-forina commented Jul 3, 2019 •
edited

So with atlasmap-data-mapper v.1.40.0 this works for me. I'm updating the deps now.

yarn why @atlasmap/atlasmap-data-mapper 
yarn why v1.17.0
[1/4] 🤔  Why do we have the module "@atlasmap/atlasmap-data-mapper"...?
[2/4] 🚚  Initialising dependency graph...
warning Resolution field "@patternfly/patternfly@2.6.6" is incompatible with requested version "@patternfly/patternfly@1.0.250"
warning Resolution field "@patternfly/patternfly@2.6.6" is incompatible with requested version "@patternfly/patternfly@^2.8.1"
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "@syndesis/atlasmap-assembly#@atlasmap/atlasmap-data-mapper@1.40.0"
info Reasons this module exists
   - "_project_#@syndesis#atlasmap-assembly" depends on it

@riccardo-forina
Copy link
Collaborator

Uhm it looks like that's the latest version @heiko-braun

@riccardo-forina
Copy link
Collaborator

Here's what I see creating an integration using the Todo connector.
image

@mcada
Copy link
Contributor Author

mcada commented Jul 3, 2019

Not the best recording but the issue is visible.
As the input query you can just use insert into contact values(:#ASDF)

out

@riccardo-forina
Copy link
Collaborator

Thanks, I tried again and I can't reproduce it. Tried locally and on staging. Can you check if the iframe where atlasmap is embedded is taking the full height?

@mcada
Copy link
Contributor Author

mcada commented Jul 3, 2019

screenshot_20190703_125002

@riccardo-forina
Copy link
Collaborator

riccardo-forina commented Jul 3, 2019 •
edited

I just tried with the branch 1.7.x and it's working fine for me. Can I ask you to check something else on the rendered html? The wrapper around the iframe and the iframe itself should look something like this:

<section class="pf-c-page__main-section pf-m-no-padding" style="overflow: hidden;"><iframe name="atlasmap-frame" srcdoc="<!doctype html>
<html lang=&quot;en&quot;>
<head>
  <meta charset=&quot;utf-8&quot;>
  <title>Atlasmap</title>
  <base href=&quot;/dm&quot;>

  <meta name=&quot;viewport&quot; content=&quot;width=device-width, initial-scale=1&quot;>
  <link rel=&quot;icon&quot; type=&quot;image/x-icon&quot; href=&quot;favicon.ico&quot;>
</head>
<body style=&quot;background: transparent;&quot;>
  <app-root></app-root>
  <script type=&quot;text/javascript&quot; src=&quot;/atlasmap-runtime.js&quot;></script>
  <script type=&quot;text/javascript&quot; src=&quot;/atlasmap-polyfills.js&quot;></script>
  <script type=&quot;text/javascript&quot; src=&quot;/atlasmap-styles.js&quot;></script>
  <script type=&quot;text/javascript&quot; src=&quot;/atlasmap-scripts.js&quot;></script>
  <script type=&quot;text/javascript&quot; src=&quot;/atlasmap-vendor.js&quot;></script>
  <script type=&quot;text/javascript&quot; src=&quot;/atlasmap-main.js&quot;></script></body>
</html>

" frameborder="0" allowtransparency="" style="width: 100%; height: 100%; line-height: 0;"></iframe></section>

The important bits are the two inline styles applied to the section and iframe elements.

If that looks ok, the next step would be to check the nodes above the section one. The expected styling should be something like this:

layout-debug

Basically, hovering over each element should highlight a node tall as the available viewport height. If not, there is something weird either in the built CSS or in the way the browser is interpreting it.

@mcada
Copy link
Contributor Author

mcada commented Jul 3, 2019

Ok so I found out that I did not have the latest-stable chrome version. When I updated it works. Do we still want to investigate why it is not rendered correctly on older version or should I close the issue?

@heiko-braun
Copy link
Collaborator

heiko-braun commented Jul 3, 2019 •
edited

It might not related to the version, but the fact that a new chrome installation wiped some cached data or settings.

@mcada
Copy link
Contributor Author

mcada commented Jul 3, 2019

Probably not, I tried cleaning everything and private window - the issue was always present.

@heiko-braun
Copy link
Collaborator

@mcada based on your latest comment I would suggest we lower the priority?

@mcada mcada added prio/p2 The priority of a bug. p1 means low and removed prio/p0 The priority of a bug. p0 means blocking labels Jul 4, 2019
@heiko-braun heiko-braun removed this from the Sprint 48 (4/4) milestone Jul 11, 2019
@igarashitm igarashitm mentioned this issue Jul 25, 2019
Closed
@heiko-braun heiko-braun removed the notif/triage The issue needs triage. Applied automatically to all new issues. label Aug 1, 2019
@igarashitm igarashitm mentioned this issue Aug 15, 2019
Closed
@heiko-braun heiko-braun added zenhub/backlog cat/bug A bug which needs fixing labels Sep 7, 2019
@heiko-braun heiko-braun assigned igarashitm and unassigned igarashitm Sep 7, 2019
@heiko-braun
Copy link
Collaborator

Migrated to https://issues.jboss.org/browse/ENTESB-11446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

@riccardo-forina riccardo-forina

Labels
cat/bug A bug which needs fixing closed/migrated prio/p2 The priority of a bug. p1 means low source/qe Raised by QE zenhub/backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@igarashitm @heiko-braun @riccardo-forina @mcada