Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Conditional Flow] datashape change is not propagated into condition #6186

Closed
mcada opened this issue Jul 17, 2019 · 7 comments
Closed

[Conditional Flow] datashape change is not propagated into condition #6186

mcada opened this issue Jul 17, 2019 · 7 comments
Assignees
Labels
cat/bug A bug which needs fixing closed/migrated prio/p1 The priority of a bug. p1 means high source/qe Raised by QE zenhub/backlog

Comments

@mcada
Copy link
Contributor

mcada commented Jul 17, 2019

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

On following gif I have an integration with SQL -> split -> conditional flow -> log. When I change SQL to different operation, the change is not propagated into the datamapper in one condition flow. I tried similar scenario without split step and the issue was still present. Not even an error is shown in data mapper.
Workaround is to configure main conditional flow, change nothing and click done. Then datamapper shows correct input.

out

@mcada mcada added prio/p0 The priority of a bug. p0 means blocking source/qe Raised by QE labels Jul 17, 2019
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Jul 17, 2019
@heiko-braun heiko-braun added this to the Sprint 49 milestone Jul 17, 2019
@christophd
Copy link
Contributor

Yep, you have to revisit the conditional flow configuration page in order to trigger the shape change propagation to all sub-flows. It should be done automatically but I think this is a valid workaround for now as conditional flows is marked as tech preview for 7.4.

We may consider to lower the prio to p1 for these reasons. @heiko-braun WDYT?

@christophd
Copy link
Contributor

I think this one needs to be tackled in the UI, too so adding @gashcrumb 😄

@gashcrumb
Copy link
Contributor

Yup, as you say that data shape is only propagated when the conditional flow step is configured. I agree on it being a p1 too, that's a workaround we can release note.

@heiko-braun
Copy link
Collaborator

@christophd What is the workaround?

@christophd
Copy link
Contributor

@heiko-braun as workaround the user has to open the conditional flows configuration page once more to get this working as expected.

@heiko-braun heiko-braun added prio/p1 The priority of a bug. p1 means high and removed prio/p0 The priority of a bug. p0 means blocking labels Jul 17, 2019
@heiko-braun
Copy link
Collaborator

I've changed it to p1 after talking to @gaughan

@christophd christophd removed the notif/triage The issue needs triage. Applied automatically to all new issues. label Aug 1, 2019
@christophd christophd added the cat/bug A bug which needs fixing label Sep 3, 2019
@heiko-braun
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug A bug which needs fixing closed/migrated prio/p1 The priority of a bug. p1 means high source/qe Raised by QE zenhub/backlog
Projects
None yet
Development

No branches or pull requests

4 participants