Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New maintainer #36

Closed
cmcaine opened this issue Sep 29, 2017 · 4 comments
Closed

New maintainer #36

cmcaine opened this issue Sep 29, 2017 · 4 comments

Comments

@cmcaine
Copy link
Collaborator

cmcaine commented Sep 29, 2017

I can take over maintenance of this project, if you like.

My npm username is cmcaine. I believe ownership can be transferred like so: slevithan/xregexp#11

I'm interested to know why you think Mozilla is compromising privacy for convenience. Is it the DRM issue?

@ghost
Copy link

ghost commented Sep 30, 2017

Hi, I can definitely give you the appropriate rights here and on npm as well!

I was referring to the google analytics deployed on supposedly internal pages (That were in fact AMO pages), which came in the wake of the big browser is watching you ad campaign they led. But I understand that's a very personal opinion.

@ghost
Copy link

ghost commented Sep 30, 2017

So, maintenance rights have been given, on npm and github. :)

@ghost ghost closed this as completed Sep 30, 2017
@cmcaine
Copy link
Collaborator Author

cmcaine commented Oct 1, 2017

I think Mozilla's response to the issue was good, though I'm disappointed that they were ignoring DNT beforehand: mozilla/addons#3145

When I try to commit to the repo, I get

remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "continuous-integration/travis-ci" is expected.
To github.com:michael-zapata/web-ext-types.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:michael-zapata/web-ext-types.git'

I imagine I could push to another branch then merge. Do you have a strong preference for that style? Do you use a helper to make it easier?

Because this seems like a lot when I already know that the tests pass:

git checkout -b chore/change-maintainer
# edits, adds and commits
git push -u origin
git checkout master
git merge chore/change-maintainer
git branch -d chore/change-maintainer
git push -d origin chore/change-maintainer

@ghost
Copy link

ghost commented Oct 2, 2017

That's because master is protected, I tend to rely on some level of CI to ensure master is always green, fool-proofing it against my tired/hasty/... self. You can always disable the check though.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant