Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 Make angular demo run with standalone dependencies to prevent errors when required version of wrappers differ #490

Open
schilchSICKAG opened this issue May 15, 2024 · 2 comments
Assignees
Labels
package/angular Issues affecting the angular wrappers

Comments

@schilchSICKAG
Copy link
Contributor

schilchSICKAG commented May 15, 2024

Description

After multiple problems with e2e tests not working as expected, we traced the problem to an error while building our angular demo project. This tries to share the version of @angular/core and @angular/forms with the one provided in @synergy-design-system/angular. This leads to problems with the angular compiler, as the versions may differ. In this case (e.g. when @synergy-design-system/angular has a different version of one of this packages, the local module resolution of angulars build system does not work anymore. However, the server itself is still starting up. This leads to the problem that selectors created via Playwright will never run in a timeout, making the tests stay in sort of a limbo between death and live.

This is NOT a problem that users may likely face in the wild, as it is caused by the dedupe mechanism used in pnpm and the usage of a monorepo that locally links the packages together.

Rationale

We have to make sure updates of peerDependencies do not cause problems with the build of the demo to make tests less flaky.

@schilchSICKAG schilchSICKAG added the package/angular Issues affecting the angular wrappers label Jun 4, 2024
@schilchSICKAG
Copy link
Contributor Author

schilchSICKAG commented Jun 4, 2024

This was tried in #502. However, it does not work correctly, because there are multiple issues with this at pnpms side.

@schilchSICKAG
Copy link
Contributor Author

During development of #508, we noticed that this is also happening in our react vite builds. However, in this case, only production builds seem to have the problem. This may be some internal problem when using esbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/angular Issues affecting the angular wrappers
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants