Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying "Rotate Order" to the vertices different from the first crashes Synfig #1163

Open
FirasH opened this issue Feb 16, 2020 · 11 comments
Open

Comments

@FirasH
Copy link
Member

FirasH commented Feb 16, 2020

Synfig version & platform:
Master: 09220e

Issue description:

  1. Launch Synfig
  2. Select the "Spline Tool" (only Outline Layer)
  3. Draw a Spline on canvas with 2 vertices (it is enough to cause the crash)
  4. Go to the Parameters window and expand the list of "Vertices"
  5. Select "Vertex 002" and right-click > Rotate Order

Synfig crashes consistently.

The issue can be reproduced even with more vertices. If you add more vertices in step 3, the crash is still reproducible if the vertex selected in step 5 is not the first one.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@rodolforg
Copy link
Contributor

rodolforg commented Feb 18, 2020

Duplication of #280 ?

@rodolforg
Copy link
Contributor

rodolforg commented Feb 18, 2020

Anyway, what does "rotate order" mean?
I can't figure it out.
And how is it supposed to work?

@ebarranco
Copy link

I remember trying to find out what it does some time ago and only found this on the wiki:

Rotate Order: Doesn't do anything.

Here in the "Specific actions for Width Points" section.

I always suspected that it was something to do with tangents back a the day when they had different colors and direction of Sewing Splines It was less ambiguous.

@morevnaproject
Copy link
Member

Rotate Order changes order of vertices.
The effect of this operation is visible on Un-looped splines.

For example, right-clicking (1) on this vertex and choosing "Rotate Order" ...
screenshot_001

...results in this:
screenshot_002

@rodolforg
Copy link
Contributor

rodolforg commented Jul 21, 2020

Not reproducible in 1.3.15 (production. debug version has an assert that ruins everything :P)

BTW, @morevnaproject , this "rotate order" is a non-intuitive name. For me at least :P

@morevnaproject
Copy link
Member

this "rotate order" is a non-intuitive name. For me at least :P

what could be the better name? ^__^

@FirasH
Copy link
Member Author

FirasH commented Jul 25, 2020

Does not crash with current master 8b93aa1

@rodolforg
Copy link
Contributor

@FirasH it crashes in debug build due to that pointed assert(). Asserts are ignored in production builds.

@morevnaproject I don't know XD What about "Set as first vertex"? :P

@morevnaproject
Copy link
Member

"Set as first vertex" - this is better, but it doesn't tells that other points are reordered too. ^__^"

@FirasH
Copy link
Member Author

FirasH commented Jul 27, 2020

Maybe something more specific like “Rotate order of vertices”

@morevnaproject
Copy link
Member

That would be better than just "Rotate order". ^__^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants