Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate old Widget_Defaults container to Gtk::Grid #1787

Closed
Keyikedalube opened this issue Oct 19, 2020 · 4 comments · Fixed by #1816
Closed

Migrate old Widget_Defaults container to Gtk::Grid #1787

Keyikedalube opened this issue Oct 19, 2020 · 4 comments · Fixed by #1816

Comments

@Keyikedalube
Copy link
Contributor

Issue description:

  1. Gtk::Table to Gtk::Grid
  2. Gtk::VBox   to Gtk::Grid

Screenshot from 2020-10-19 10-46-43

Both Table and Grid has attach() functions but their arguments differ. You've to adapt the existing Table container to Grid by eliminating most of its arguments.

Pen and paper is a good starting point to visualize how each widgets are supposed to be attached :)

@Keyikedalube

This comment has been minimized.

@Keyikedalube Keyikedalube changed the title Migrate Widget_Defaults old widgets container to Gtk::Grid Migrate old Widget_Defaults container to Gtk::Grid Oct 19, 2020
@Keyikedalube
Copy link
Contributor Author

Hacktoberfest is ending soon and I doubt this issue will be resolved at all from new contributors

There are more widgets apart from widget_defaults that use Gtk::Table. Maybe, I could resolve all of them in one PR :)

  • widget_coloredit
  • widget_waypoint

@rodolforg @ice0 opinion?

@ice0
Copy link
Collaborator

ice0 commented Oct 29, 2020

I think this is a good idea :)

@Keyikedalube
Copy link
Contributor Author

I'm working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants