Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added seekpos method for FileSystemNative::ReadStream #2224

Merged
merged 1 commit into from Oct 18, 2021
Merged

Added seekpos method for FileSystemNative::ReadStream #2224

merged 1 commit into from Oct 18, 2021

Conversation

ice0
Copy link
Collaborator

@ice0 ice0 commented Jul 13, 2021 •
edited

This fixes non-working seekg method.

Related issue: #2219

I'm not sure if it will work correctly with files larger than 2GB, in my opinion it is better to replace our own implementation with the standard ifstream class.

@ice0
Added seekpos method for FileSystemNative::ReadStream
2bc01a8 
This fixes non-working `seekg` method.

Related issue: synfig#2219
@ice0 ice0 added the Bug label Jul 13, 2021
@ice0 ice0 mentioned this pull request Jul 13, 2021
Closed
rodolforg
rodolforg approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@rodolforg rodolforg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works! \o/

(tellg() keeps stating the same position, but now seekg() works indeed!)

@rodolforg
Copy link
Contributor

rodolforg commented Jul 13, 2021 •
edited

This PR fixes #2219

@rodolforg
Copy link
Contributor

rodolforg commented Jul 13, 2021 •
edited

hmm… would it be good to implement seekoff() too, right?
http://www.cplusplus.com/reference/streambuf/streambuf/seekoff/

@rodolforg rodolforg linked an issue Oct 17, 2021 that may be closed by this pull request
Incorrect framerate when importing image sequence #2219
Closed
@ice0 ice0 merged commit 19a88f4 into synfig:master Oct 18, 2021
@ice0 ice0 added this to Ready to backport in v1.4.3 Oct 18, 2021
@ice0 ice0 deleted the fix-seekg branch October 18, 2021 07:13
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Oct 18, 2021
@ice0 @morevnaproject
Added seekpos method for FileSystemNative::ReadStream (synfig#2224)
73187b9 
This fixes non-working `seekg` method.

Related issue: synfig#2219
@morevnaproject
Copy link
Member

Backported to 1.4.x branch.

@morevnaproject morevnaproject moved this from Ready to backport to Backported in v1.4.3 Oct 18, 2021
@rodolforg rodolforg removed the Backport label Feb 2, 2024
@rodolforg rodolforg added this to the v1.4.3 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodolforg rodolforg rodolforg approved these changes

Assignees
No one assigned
Labels
Bug
Projects
No open projects
v1.4.3
Backported
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

Incorrect framerate when importing image sequence
3 participants
@ice0 @rodolforg @morevnaproject