Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted layer size update as a separate function #2282

Merged
merged 1 commit into from Aug 30, 2021
Merged

Extracted layer size update as a separate function #2282

merged 1 commit into from Aug 30, 2021

Conversation

ice0
Copy link
Collaborator

@ice0 ice0 commented Aug 23, 2021 •
edited

Refactoring: duplicate code is extracted into a separate function.

@ice0 ice0 requested a review from rodolforg August 23, 2021 04:50
rodolforg
rodolforg previously approved these changes Aug 29, 2021
View reviewed changes
Copy link
Contributor

@rodolforg rodolforg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving right away in case of you won't change the method parameter list.
It does clean up code without behavior change. :)

@ice0 ice0 force-pushed the refactor-canvas-interface branch from fc742a4 to 1693aa2 Compare August 30, 2021 06:09
@ice0 ice0 merged commit 3ede603 into synfig:master Aug 30, 2021
@ice0 ice0 deleted the refactor-canvas-interface branch August 30, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keyikedalube Keyikedalube Keyikedalube left review comments

@rodolforg rodolforg rodolforg approved these changes

Assignees
No one assigned
Labels
Code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ice0 @rodolforg @Keyikedalube