Add Handle type to Skeleton and SkeletonDeformation layers #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid misunderstandings This commit fixes some Layer_Skeleton::Handle::cast_dynamic() and Layer_SkeletonDeformation::Handle::cast_dynamic() casts. Sometimes coder supposed that it would check the specific layer class, but they only dynamically cast to Layer class itself.
rodolforg
force-pushed
the
create-skeleton-layer-handle-type
branch
from
955738c
to
9d349b7
Compare
morevnaproject
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid misunderstandings
This commit fixes some Layer_Skeleton::Handle::cast_dynamic()
and Layer_SkeletonDeformation::Handle::cast_dynamic() casts.
Sometimes coder supposed that it would check the specific layer
class, but they only dynamically cast to Layer class itself.