cleanup and fix Intersector class: documentation and conic curves #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodolforg
force-pushed
the
improve-intersector
branch
from
b006107
to
e90eeb1
Compare
10 tasks
ice0
reviewed
Oct 13, 2021
- Missed parenthesis mistake in Bhaskara solution for quadratic equations - Forgot to return correct signal according to curve direction for some 'special' cases This is another fix for synfig#442
Fix in Intersector for quadratic (conic) bezier curves solves the old hit check for Circle reported in synfig#442
rodolforg
force-pushed
the
improve-intersector
branch
from
e90eeb1
to
ec01f7b
Compare
ice0
approved these changes
Oct 14, 2021
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New fix for #442