Added basic support for Gtk theme #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use Gtkmm methods rather GTK
and avoid code repetition
these are now looked up by name
Almost all GTK methods using icons from the default GTK theme. Unfortunately, we can't change the IconTheme name if we get it from the default screen with the `Gtk::IconTheme::get_default()` method (https://docs.gtk.org/gtk3/method.IconTheme.set_custom_theme.html) > Sets the name of the icon theme that the GtkIconTheme object uses overriding system configuration. This function cannot be called on the icon theme objects returned from gtk_icon_theme_get_default() and gtk_icon_theme_get_for_screen(). Also, I didn't find a way to change the app IconTheme to a custom one. However, we can change the IconTheme for the default screen using the `Gtk::Settings` object.
Closed
morevnaproject
added a commit
to morevnaproject/morevna-builds
that referenced
this pull request
May 17, 2022
morevnaproject
added a commit
to morevnaproject/morevna-builds
that referenced
this pull request
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased PR #1508 and CMake improvements from #2624
P.S. I also excluded
Widget_InterpolationEnumbecause I'm not sure if it's needed.