Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Alpha channel resets when changing color in HSV wheel #2690

Merged
merged 1 commit into from Aug 3, 2022
Merged

fix: Alpha channel resets when changing color in HSV wheel #2690

merged 1 commit into from Aug 3, 2022

Conversation

ice0
Copy link
Collaborator

@ice0 ice0 commented Jun 17, 2022 •
edited

The alpha channel was reset because it was not saved.

@ice0 ice0 changed the title fix: Alpha channel always resets when changing color in HSV wheel fix: Alpha channel resets when changing color in HSV wheel Jun 17, 2022
rodolforg
rodolforg approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@rodolforg rodolforg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the method name should be changed to clarify it is called only as a slot for hvsColorWidget change?

@ice0
Copy link
Collaborator Author

ice0 commented Aug 2, 2022

Maybe the method name should be changed to clarify it is called only as a slot for hvsColorWidget change?

Agree.

@ice0 ice0 merged commit f05ee82 into synfig:master Aug 3, 2022
@ice0 ice0 deleted the fix-hsv-color-wheel2 branch August 3, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodolforg rodolforg rodolforg approved these changes

Assignees
No one assigned
Labels
Code quality GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ice0 @rodolforg