fix!: mod_imagemagick didn't import anything #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it uses application name "convert" to convert the desired image into another temporary one with a well-known format (PNG). This temporary image would then be really imported (via another module - not very clever; what if it is not loaded?) The problem is the temporary file is automatically named without any extension. In the end, Synfig can't load it, as it depends on the extension to select the Importer. Tested with a XPM file because XPM seems to be only loaded by imagemagick https://filesamples.com/formats/xpm BREAKING CHANGE: Synfig library API changed: - Two methods of FileSystemTemporary has a new optional parameter: extension: - generate_system_temporary_filename - generate_system_temporary_filename_base
rodolforg
force-pushed
the
fix-imagemagick-importer
branch
from
46355f4
to
5d01a68
Compare
ice0
changed the title
ice0
approved these changes
Aug 12, 2022
|
Merged. Thank you! |
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Aug 13, 2022
with the fix provided by PR synfig#2789 (commit 25f28b1), it was finally viable to implement this (simple) feature :) fix synfig#965
ice0
pushed a commit
that referenced
this pull request
Aug 15, 2022
|
Thank you very much, I'm sure it will be very helpful for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it uses application name "convert" to convert the desired image
into another temporary one with a well-known format (PNG).
This temporary image would then be really imported
(via another module - not very clever; what if it is not loaded?)
The problem is the temporary file is automatically named without any
extension.
In the end, Synfig can't load it, as it depends on the extension to select
the Importer.
Tested with a XPM file because XPM seems to be only loaded by imagemagick
https://filesamples.com/formats/xpm
BREAKING CHANGE: Synfig library API changed: