Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for SVG image sequence with lst files #2795

Merged
merged 1 commit into from Aug 15, 2022

Conversation

rodolforg
Copy link
Contributor

with the fix provided by PR #2789 (commit 25f28b1),
it was finally viable to implement this (simple) feature :)

fix #965

with the fix provided by PR synfig#2789 (commit 25f28b1),
it was finally viable to implement this (simple) feature :)

fix synfig#965
@ice0 ice0 changed the title feat: support sequence of svg images with lst files feat: added support for SVG image sequence with lst files Aug 15, 2022
@ice0 ice0 merged commit e289d69 into synfig:master Aug 15, 2022
@ice0
Copy link
Collaborator

ice0 commented Aug 15, 2022

Merged. Thank you!

@ice0
Copy link
Collaborator

ice0 commented Aug 17, 2022

@rodolforg
Forgot to ask: does this function only work when mod_imagemagick is enabled?

@rodolforg
Copy link
Contributor Author

Yes

@rodolforg
Copy link
Contributor Author

Same for tiff.
Ppm can be with imagemagick or mod_ppm
Jpeg can be with imagemagick or mod_jpeg

@rodolforg rodolforg deleted the fix-965-lst-svg branch August 17, 2022 13:41
@rodolforg
Copy link
Contributor Author

As alternative we could have ffmpeg (if compiled with librsvg support) or create a Magick++ importer

@rodolforg
Copy link
Contributor Author

Should I create a Magick++ importer?

@ice0
Copy link
Collaborator

ice0 commented Sep 11, 2022

Should I create a Magick++ importer?

I was planning to discuss switching from ImageMagick to GraphicsMagick because we have issues with ImageMagick on Windows and macOS (or maybe add a mod_graphicsmagick as alternative).

The Autotools build currently does not work on macOS because ImageMagick adds -omp flags that cannot be handled correctly by libtool/clang toolchain. This can be solved by switching to GCC compiler for autotools build, but I prefer to use clang on macOS (since it's a native compiler). Anyway CMake build works fine so it's not a critical issue.

Another issue is broken MSYS2 and macOS builds (with latest ImageMagick). This can be resolved by adding tests to MSYS2/Homebrew so they can't update ImageMagick until issue is fixed.

Also I am not sure if switching to GraphicsMagick will fix this issues.

So yes, it would be a nice feature if you're interested, but we can skip it if it's too complicated.

rodolforg added a commit to rodolforg/synfig that referenced this pull request Jan 30, 2024
Suggested in discussion of synfig#2795
synfig#2795 (comment)

to allow SVG import in .lst files, without imagemagick module
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jan 30, 2024
Suggested in discussion of synfig#2795
synfig#2795 (comment)

to allow SVG import in .lst files, without imagemagick module
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jan 31, 2024
Suggested in discussion of synfig#2795
synfig#2795 (comment)

to allow SVG import in .lst files, without imagemagick module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature resquest: Support sequence of svg images with lst files.
2 participants