feat: Added support for scrolling through text in text paragraph dialog

[mohamedAdhamc]

before:

before_vid.mp4

After:

after_vid.mp4

One thing I'm not sure about though... with the current implementation if the user manually resized the dialog to a greater vertical size, if he then deletes a line then the dialog is auto-adjusted to the size fitting to the number of lines he has, is this okay? or should it be that if it's manually resized the size of the resize is the new minimum size?

Also I just thought of this, should this auto shrink be only when we are deleting the last line?

p.s. excuse the horrendous video quality I had to compress to upload xD.

[ice0]

One thing I'm not sure about though... with the current implementation if the user manually resized the dialog

Can we detect manual resizing?

[mohamedAdhamc]

Can we detect manual resizing?

not in a direct way, but if needed I think we can use the button_press,button_release, and check_resize signal to get insight onto whether the resize was by mouse (manual). i.e. if between the button press and release there was a resize then this was a manual resize. And to be even more sure we could even make sure that during this no key was pressed.

[ice0]

Can we detect manual resizing?

not in a direct way, but if needed I think we can use the button_press,button_release, and check_resize signal to get insight onto whether the resize was by mouse (manual). i.e. if between the button press and release there was a resize then this was a manual resize. And to be even more sure we could even make sure that during this no key was pressed.

If you notice that something is starting to get overcomplicated (like here), then you may just be moving in the wrong direction.
Please check Gtk::ScrolledWindow widget.

[mohamedAdhamc]

If you notice that something is starting to get overcomplicated (like here), then you may just be moving in the wrong direction. Please check Gtk::ScrolledWindow widget.

I agree, also yes I think I saw scrolled windows being used with text-views so yes I think it'll probably make sense, I'll look into it.

[mohamedAdhamc]

@ice0 done.

[mohamedAdhamc]

@ice0 done, this is the new default size

[ice0]

Merged. Thank you!

[mohamedAdhamc]

Great! hopefully many more to come :)