Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Embed layer" doesn't embed ValueBase nodes [$100] #426

Open
zozorg opened this issue Sep 10, 2017 · 10 comments · May be fixed by #3029
Open

"Embed layer" doesn't embed ValueBase nodes [$100] #426

zozorg opened this issue Sep 10, 2017 · 10 comments · May be fixed by #3029
Labels
Projects

Comments

@zozorg
Copy link

zozorg commented Sep 10, 2017

Synfig version & platform:
linux 1.3.4

Issue description:
When using "embed layer", valuebase nodes do appear in the newly created canvas, as they should ; but they have no influence, the values actually used are still those of the original file.


There is a $100 open bounty on this issue. Add to the bounty at Bountysource.

@zozorg
Copy link
Author

zozorg commented Sep 30, 2017

... this appears to only happen when the valuebase is used inside of a group layer.
If it's in the "root", the value is correctly embedded.

To reproduce :

  • Create two circles A and B, put B inside a group layer
  • Export their radii "a" and "b"
  • Import this in a new animation and embed it.
  • You now have two supposedly independent animations
  • Everything works fine with A
  • Both B circles have their radii connected to "b" of the original animation. In the newer animation, "b" does nothing.

@zozorg
Copy link
Author

zozorg commented Oct 2, 2017

Posted a $30 bounty for this, in addition to this $50 one

@morevnaproject morevnaproject added this to Backlog in Releases Oct 3, 2017
@morevnaproject
Copy link
Member

Hello @zozorg! Thank you very much for support! My apologies for delay, right now our developer is working on #314 and it takes longer than we expected. We will get back to this issue as soon as possible.
Meanwhile I will try to spread a word about bounty - maybe we will get some extra developers interested.

@zozorg
Copy link
Author

zozorg commented Oct 3, 2017

You're welcome, Synfig really deserves more support!
Currently I can circumvent this problem by manually editing the .sif file, replacing use="originalanimation.sif#:b" by use="b" ... I hope I won't have to do this for long though :-p

@zozorg
Copy link
Author

zozorg commented Nov 20, 2017

+$10 bounty, total $40

@zozorg
Copy link
Author

zozorg commented Dec 1, 2017

+$20 bounty, total $60

@zozorg
Copy link
Author

zozorg commented Dec 18, 2017

now that the filter layer/stack is done, +$40 bump on this one!
total $100

@morevnaproject morevnaproject changed the title "Embed layer" doesn't embed ValueBase nodes "Embed layer" doesn't embed ValueBase nodes [$100] Mar 26, 2018
@mohamedAdhamc
Copy link
Contributor

mohamedAdhamc commented Jan 26, 2023

hmm, is this issue and bounty still active ? If so I think I would like to give it a try.

@mohamedAdhamc
Copy link
Contributor

mohamedAdhamc commented Mar 18, 2023

I believe this hasn't been fixed yet (5 years now O_o), I just reproduced the issue on master. I will be investigating this and hopefully submitting a pr with a fix soon : ).

@mohamedAdhamc
Copy link
Contributor

hey @zozorg, if you're still active here could you test out the functionality ? : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Releases
Backlog
Development

Successfully merging a pull request may close this issue.

3 participants