"View" -> "Toolbar" menu item is not active

[morevnaproject]

"Toolbar" menu item in "View" menu is not active.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[morevnaproject]

Possibly worth to take a look at a19e558

[bajajvinamr]

@morevnaproject I would like to fix this issue

[ice0]

@bajajvinamr it's yours now :)

[kamal-kaur04]

Hii @morevnaproject,
I would like to take this issue if it's not assigned already.
Thank you

[ankit-kumar-dwivedi]

Great @kamal-kaur04 assigning you this one.

[kamal-kaur04]

Hii @morevnaproject
Can you please tell the expected behavior(purpose) of Toolbar?

[morevnaproject]

This command should show/hide this toolbar -

[kamal-kaur04]

@morevnaproject I have tried to do this but I am not able to find the key that binds this whole toolbar. Can you please help me out with this?

[ankit-kumar-dwivedi]

@morevnaproject I have tried to do this but I am not able to find the key that binds this whole toolbar. Can you please help me out with this?

AFAIK this uistring is defined in app.cpp and only for starting elements of toolbar viz save, save all, render etc.

The only possible way I see is to define a getter for the widget(toolbar) and change it's property i.e hide/unhide accordingly.

@ice0 However this doesn't sound like how other things are being handled. So is there a better way to do this?

[ice0]

@kamal-kaur04 you can start to dig from Edit->Preferences->Show file toolbar.

When you switch it off, and restart Synfig - you will see that part of the toolbar is hidden.
Try to search thru the code by the App::show_file_toolbar and this must lead you here:

synfig/synfig-studio/src/gui/canvasview.cpp

Lines 1135 to 1141 in 9e189c3

	displaybar = manage(new class Gtk::Toolbar());
	displaybar->set_icon_size(iconsize);
	displaybar->set_toolbar_style(Gtk::TOOLBAR_BOTH_HORIZ);
	// File
	if (App::show_file_toolbar) {
	displaybar->append( *create_action_toolbutton( App::ui_manager()->get_action("/toolbar-main/new") ) );

The problem is a little bit harder, and you can't use approach used in View->Show menubar because displaybar is not unique for application, and every CanvasView has it's own Toolbar/displaybar.

But don't give up. This is a good way to better understand how Synfig works. You will learn a little bit about CanvasView and how to get active CanvasView.

Also i want to ask: did you have issues with compiling/testing? How long does it take? I have a few ideas on how to improve this, but I don’t know if this is necessary now.

@ankit-kumar-dwivedi

However this doesn't sound like how other things are being handled. So is there a better way to do this?

I think that would be good enough. If someone finds a better way, we can always refactor it later :)

[kamal-kaur04]

@ice0 @ankit-kumar-dwivedi when I tried the approach like menubar, was able to hide/show the icons referenced by the key(toolbar-main). But it doesn't show the required behavior for sure. Thank you for your take on the issue.
No issues in the compilation. But it takes long time(5-10 mins).

[rodolforg]

@kamal-kaur04 if your PC has more than 1 core, you can increase the number of jobs (threads) the build system uses. This should speed up your compilation. By default, autotools are set to 2 threads only. See build.conf file.

And if you're building via 2-build-debug.sh script, and as your PR is just GUI stuff and without any file adding/removal, you could call 2-build-debug.sh studio make.

[kamal-kaur04]

Okay. Thank you @rodolforg

[ice0]

Also you can run make install -j <number_of_threads> inside _debug directory.

For example if you are changed synfig/synfig-studio/src/gui/canvasview.cpp file, then go to
_debug/synfig/synfig-studio/src/gui/ and run make install -j4. If there is no Makefile in this directory, then go up to the parent directory.

[morevnaproject]

when I tried the approach like menubar, was able to hide/show the icons referenced by the key(toolbar-main). But it doesn't show the required behavior for sure. Thank you for your take on the issue.

Yes, that's a different toolbar. ^__^
The code needs to look for active document and find it's UI (canvasview). Then it should call a function (you probably need to write this function), which shows/hides a toolbar in canvasview.

[kamal-kaur04]

Thank you @ice0 @morevnaproject , I am trying to fix this. Will be able to do for sure. :)

[ankit-kumar-dwivedi]

@kamal-kaur04 any progress on this? Let us know if you are stuck.

[ankit-kumar-dwivedi]

@kamal-kaur04 any progress on this? Let us know if you are stuck.

@kamal-kaur04 are you working on this any more?

[ARYA-BHARDWAJ]

@ice0, I want to work on this issue.

[ice0]

@ARYA-BHARDWAJ Sure, it's yours now )

[ARYA-BHARDWAJ]

@ice0 I guess this can be solved by changing displaybar of canvasview of current window. But I don't understand how to get canvasview of current window.

[ice0]

Please look at App::get_selected_canvas_view(). Sounds like something you are looking for :)

[morevnaproject]

Closed via #1386

[rodolforg]

This issue is already fixed in v1.4.1.