Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothieware does not support GRBL config commands #26

Closed
hgroover opened this issue Aug 23, 2020 · 2 comments
Closed

Smoothieware does not support GRBL config commands #26

hgroover opened this issue Aug 23, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@hgroover
Copy link

hgroover commented Aug 23, 2020

I am running a controller board with the Smoothieware firmware. It rejects the $$ command and $ command (see this list for differences from GRBL; https://smoothieware.org/from-grbl and note that the page is incorrect, cat /sd/config.txt is actually the cognate for $$). This plugin offers a lot of essential functionality and the Smoothieboard is not a bad CNC controller. Unfortunately it raises an error on $$ which causes Octoprint to disconnect. Admittedly it is a somewhat knuckleheaded approach in Smoothieware to do a few things differently and not support aliases. I'm reporting this as an issue not because it's a flaw in this plugin but because I believe others may try this with Octoprint + Smoothieware.

@hgroover
Copy link
Author

I cloned develop and changed a few lines to support Smoothie and it all seems to work locally (except the config parsing, I didn't expect that to work but it doesn't raise an error). The documentation from the Smoothie project was incorrect, cat /sd/config.txt is the correct substitute for $$.

Working on adding the checkbox(es) to enable this behavior into the configuration UI and running more tests, and I can do a PR when I'm done if you're interested. This is a really great plugin and very useful! Currently I've been suffering through the Smoothie native web interface which is not always responsive and doesn't handle large file uploads.

@synman
Copy link
Owner

synman commented Jan 21, 2021

if you share your code, either here, or via pull request I'm more than happy to add this to the master branch

@synman synman added good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested enhancement New feature or request and removed question Further information is requested labels Jan 21, 2021
@synman synman self-assigned this Jan 21, 2021
@synman synman added this to the v1.7.3 milestone Jan 21, 2021
@synman synman closed this as completed in cb22908 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants