Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer Overflow #7

Closed
thothloki opened this issue Sep 22, 2019 · 18 comments · Fixed by #13
Closed

Buffer Overflow #7

thothloki opened this issue Sep 22, 2019 · 18 comments · Fixed by #13
Assignees
Labels
bug Something isn't working
Milestone

Comments

@thothloki
Copy link

Hey, I have this installed and am using an EleksMana board to control a laser engraver.

The issue I am having is that octopi with Better GRBL Support is feeding the gcode file way to fast and causing a buffer overflow.
I am looking around to see if this is something I can fix myself. If so, I would fork it and make one dedicated to EleksMaker style machines. Most other softwares I use wait for a carriage return from grbl before sending another gcode line.

Any help is appreciated.

@synman
Copy link
Owner

synman commented Sep 22, 2019

This plugin was developed using an ekeksmaker laser engraver as it's reference device.

Have you changed any of its defaults?

What software are you using to generate your gcode? We may find the answer there.

@thothloki
Copy link
Author

thothloki commented Sep 22, 2019

I have not changed any defaults yet.
I am using T2Laser for gcode generation. I think I found what might be an issue that I am going to test later today. T2 slims down the gcode to be as efficient as possible as shown below. I can can uncheck this method to add all the G01 commands back in
G21
G90
F500
M05
G00X0Y0F500
G92X101.5Y77.5
G90
M03 S0
G01 X99 Y155 M03 S0
X99.2 M03 S255
X100.4 Y155 M03 S255
X100.6 M03 S0
X100.4 Y154.8 M03 S0
X100.2 M03 S255
X99 Y154.8 M03 S255
X98.8 M03 S0
X99 Y154.6 M03 S0
X99.2 M03 S255
X100.4 Y154.6 M03 S255
X100.6 M03 S0
X100.4 Y154.4 M03 S0
X100.2 M03 S255

@synman
Copy link
Owner

synman commented Sep 22, 2019

Thank you for posting the "optimized" T2 code. Let me know how it goes with that option unselected. I've been waiting to see what the T2 generated gcode looks like (see the invalid ticket opened previously).

@thothloki
Copy link
Author

I dealt with this issue with the GRBL support plugin years ago and gave up in frustration. That is when i found out about the optimized code.
When I posted this question, i was looking at the code and it came to me after I had posted, that the optimized code was an issue.
What programs have you tested with? Lightburn? EleksCAM? BCL?

@synman
Copy link
Owner

synman commented Sep 22, 2019

Lightburn is all I use. I'm more than happy to add additional gcode style support (where feasible) but need sample gcode to feed my own machine to figure it out.

@thothloki
Copy link
Author

here is a sample of T2Laser gcode

snoopy3.zip

@synman
Copy link
Owner

synman commented Sep 22, 2019

Thank you! Guess I'm ready to hop back in and clear the backlog.

@thothloki
Copy link
Author

thothloki commented Sep 22, 2019

Ok. So i got machine code out of T2. When I send it, here is the error
error
here is the gcode
snoops3.zip

Is there a way you could send me a Lightburn gcode file for me to compare?

@synman
Copy link
Owner

synman commented Sep 22, 2019

I'll send you back Snoopy if you want to share the source (assuming it is not copyrighted).

@synman
Copy link
Owner

synman commented Sep 22, 2019

Is snoops3 without Optimization enabled? And snoopy3 is with optimization?

@thothloki
Copy link
Author

snoopy-clipart-dancing-coloring-2

it is just a line are drawing of snoopy from the Peanuts
Yes, it is the one without optimization

@synman
Copy link
Owner

synman commented Sep 22, 2019

Very cool. Thanks for all the details. This is sufficient for me to engage. Going to classify this as a bug once I'm at my PC.

@thothloki
Copy link
Author

Thank you. Please let me know. I am excited to get my 2 laser engravers and my little homemade cnc mill using this

@thothloki
Copy link
Author

Please let me know if there is any way I can help

@thothloki
Copy link
Author

Lightburn is all I use. I'm more than happy to add additional gcode style support (where feasible) but need sample gcode to feed my own machine to figure it out.

so I tried using a lightburn gcode file and am getting the same error

@thothloki
Copy link
Author

Ok. I figured out what was causing the overflow in the gcode. I can manually edit them (eventually building a script to auto edit them for me) to make them work. I have another problem that i will open a new issue for.

@synman synman reopened this Nov 6, 2019
@synman synman added the bug Something isn't working label Nov 6, 2019
@synman
Copy link
Owner

synman commented Nov 6, 2019

Sorry for the delay... here's snoopy gcode generated from light burn

snoopy-LB.gcode.zip

FWIW, I'm working on getting the optimized T2 Laser gcode to work.

@synman
Copy link
Owner

synman commented Dec 30, 2021

reopening this as it has remanifested in other post processors and is not limited to just the X coordinate plane.

@synman synman reopened this Dec 30, 2021
@synman synman modified the milestones: v1.7.0, V2.0.0 Dec 30, 2021
synman added a commit that referenced this issue Dec 30, 2021
@synman synman closed this as completed in aabe667 Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants