Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT - Change output firmware file name #3

Closed
bovirus opened this issue Dec 1, 2019 · 7 comments
Closed

IMPROVEMENT - Change output firmware file name #3

bovirus opened this issue Dec 1, 2019 · 7 comments

Comments

@bovirus
Copy link

bovirus commented Dec 1, 2019

@LulinPollux

I propose you to change the default scheme for firmware file saving

Currently ex. for Samsung S10 Plus - SM-G975F (ITV) the info about firmware are

SamFirm v1.3.0
Checking firmware for SM-G975F/ITV/G975FXXS3ASJG/G975FOXM3ASJD/G975FXXS3ASJA/G975FXXS3ASJG
Model: SM-G975F
Version: G975FXXS3ASJG/G975FOXM3ASJD/G975FXXS3ASJA/G975FXXS3ASJG
OS: Pie(Android 9)
Filename: SM-G975F_1_20191028103127_vseyqod81a_fac.zip.enc4
Size: 5340507952 bytes
LogicValue: nx5habv1lq8u7e0n

and the output file name is

SM-G975F_1_20191028103127_vseyqod81a_fac.zip.enc4

My proposal is to chnage it to a scheme like

Samsung_DeviceName_CountryCode_Date(YYYY.MM.DD)_IDComponents

Ex.

Samsung_SM-G975F_ITV_20191028_975FXXS3ASJG-G975FOXM3ASJD-G975FXXS3ASJA-G975FXXS3ASJG.zip

What do you think about it?

In this way is clear in teh file the info about

Device Name
Country Code
Release Date
Components version

Thanks.

@synml
Copy link
Owner

synml commented Dec 1, 2019

Hello.
Thank you for giving me the improvement.
I will update the program as you proposed.
Ex:
SM-G965N_KOO_20191021_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip

Thanks.

@synml synml closed this as completed Dec 1, 2019
@synml
Copy link
Owner

synml commented Dec 1, 2019

I updated the program to version 1.4.0.
https://github.com/LulinPollux/SamFirm-continued/releases

@bovirus
Copy link
Author

bovirus commented Dec 2, 2019

@LulinPollux
Thanks for teh update.

After the use I believe that in teh output file name could be better to have as main info after the model name the firmware reelase date (and then after Country code).

SM-G965N_20191021_KOO_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip

What do you think about it?

@synml
Copy link
Owner

synml commented Dec 2, 2019

I think it seems to be better too.
I updated the program to version 1.4.1.
https://github.com/LulinPollux/SamFirm-continued/releases

@bovirus
Copy link
Author

bovirus commented Dec 2, 2019

Thank for new version 1.4.1.
@LulinPollux

Please consder to improve it (when you can - is not necessary now just for this) as

SM-G965N_2019.10.21_KOO_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip

Change Releaase date in file name from YYYYMMDD to YYYY..MM.DD

What do you think about it?

@bovirus bovirus changed the title IMPROVEMNT - Change output firmware file name IMPROVEMENT - Change output firmware file name Dec 2, 2019
@synml
Copy link
Owner

synml commented Dec 3, 2019

I don't recommend that.
Because if there is a dot in the file name, there can be problems that can be misrecognize as an extension.
So most of them use YYYYMMDD format a lot.

@bovirus
Copy link
Author

bovirus commented Dec 3, 2019

@LulinPollux

Right. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants