Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Get commandes list by ApplicationDescription #35

Closed
oallain opened this issue Mar 19, 2021 · 2 comments · Fixed by #87
Closed

[improvement] Get commandes list by ApplicationDescription #35

oallain opened this issue Mar 19, 2021 · 2 comments · Fixed by #87
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@oallain
Copy link
Member

oallain commented Mar 19, 2021

Currently we are retrieving the list of commands that can be executed in console by launching the console and parsing the results.
This code is in

public function getCommands(): array

It is possible to do it more simply, by use
https://github.com/symfony/console/blob/4e102e4de39852a1dcd3b2169d263b88afee7fff/Application.php#L739

@Jibbarth Jibbarth added enhancement New feature or request good first issue Good for newcomers labels Mar 19, 2021
@Hraph
Copy link

Hraph commented Feb 13, 2023

Hi, why hasn't this huge improvement been integrated yet?

@oallain
Copy link
Member Author

oallain commented Feb 15, 2023

Hello @Hraph ,

We didn't have time to do it. If you feel like it, we gratefully accept PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants