New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet): Upgrade Reanimated Library #1039
Conversation
Upgrades react-native-reanimated to 3.1.0. Upgrades react-native-gesture-handler to 2.10.0. Updated SwipeToConfirm component. Added swipeToConfirmRef ref to SwipeToConfirm component and implemented it in ReviewAndSend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App now throws a lot of annoying Overriding previous layout animation...
warning. Can this be fixed?
Also I don't understand why new ref.reset()
method is needed, if there is already an animation when you change loading
prop from true to false ? I've tried to comment it out, still works as expected. Am I missing something?
Simulator.Screen.Recording.-.iPhone.14.-.2023-05-12.at.16.53.42.mp4
Unfortunately, I haven't found a way to rid that warning. Looking into it. On my Android device at least, the loading indicator and circle position would never reset and remain locked in the final state. So providing parent components a way to reset the state after certain actions (Selecting no when the alert appears in this case) fixes it. |
To archive this try to replace untitled.webm |
Looks like the warning is due to the use of |
Updated here. |
I opted to remove the old |
Description
react-native-reanimated
to3.1.0
.SwipeToConfirm
component.LayoutManager
.Type of change
Tests
QA Notes
SwipeToConfirm
component, navigate to the "ReviewAndSend" view by pasting a Bitcoin/Lightning address after tapping "Send", select "Max" amount, slide to confirm and select "No". The slider should reset prior to navigating back to the previous view.