Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update e2e workflow #1041

Merged
merged 2 commits into from May 13, 2023
Merged

chore: update e2e workflow #1041

merged 2 commits into from May 13, 2023

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 13, 2023

Speed up Docker setup step in CI

@limpbrains
Copy link
Collaborator

This is awesome, also take a look at
https://github.com/douglascamata/setup-docker-macos-action
I tried this before, but now it should work with docker compose

@pwltr
Copy link
Collaborator Author

pwltr commented May 13, 2023

@limpbrains Should we remove matrix now? We can add more test attempts if it still fails too often and it should be faster than two parallel jobs.

@limpbrains
Copy link
Collaborator

Sure, let’s give it a try. Additionally, caching is not functioning correctly in matrix mode, so we will be able to optimise for it.
To ensure it is stable, let’s run tests 3-5 times

@pwltr pwltr removed the request for review from limpbrains May 13, 2023 13:24
@pwltr pwltr requested a review from limpbrains May 13, 2023 18:06
@pwltr pwltr merged commit 9fa94ba into master May 13, 2023
4 checks passed
@pwltr pwltr deleted the test/e2e-docker-setup branch May 13, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants