Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lightning): Updated react-native-ldk #1054

Merged
merged 1 commit into from May 20, 2023
Merged

chore(lightning): Updated react-native-ldk #1054

merged 1 commit into from May 20, 2023

Conversation

Jasonvdb
Copy link
Collaborator

Description

Updates react-native-ldk that includes a fix for payments failing on first attempt. (synonymdev/react-native-ldk#125)

Linked Issues/Tasks

Fixes Add any links to GitHub issues or Asana tasks that are relevant to this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

Payments won't instantly fail and then succeed on a 2nd attempt. The node will continue to attempt making the payment until it succeeds, a timeout of 60 seconds, or a hard payment fail.

@coreyphillips
Copy link
Collaborator

I can't seem to create a release build for Android. Difficult to say why, not seeing the cause in the logs.

@Jasonvdb
Copy link
Collaborator Author

Release builds working for me. Running yarn setup-android before building?

@coreyphillips
Copy link
Collaborator

I have, yes. Was able to run the provided apk without issue. So the build seems to be a local issue I'll need to sort out.

@Jasonvdb Jasonvdb merged commit 56e28f4 into master May 20, 2023
4 checks passed
@Jasonvdb Jasonvdb deleted the ldk-v-bump2 branch May 20, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LN payments show timeout but eventually do success
2 participants