Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add polyfill for Promise.allSettled #967

Merged
merged 1 commit into from Apr 13, 2023
Merged

fix: add polyfill for Promise.allSettled #967

merged 1 commit into from Apr 13, 2023

Conversation

limpbrains
Copy link
Collaborator

Description

Currently if you try to save Slashtags profile app shows undefined is not a function error. This is because our React Native version doesn't support Promise.allSettled which is used inside hypercore library. So I'm adding it.


Type of change

Bug fix

Tests

No test

QA Notes

Open app, edit the Profile name and try to save it, the should be no errors

Bitkit Version

@limpbrains limpbrains requested review from dzdidi and Nuhvi April 13, 2023 10:00
Copy link
Collaborator

@Nuhvi Nuhvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's try this.

Copy link

@dzdidi dzdidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@limpbrains limpbrains merged commit 21f548b into master Apr 13, 2023
4 of 5 checks passed
@limpbrains limpbrains deleted the all-settled branch April 13, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants