Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Local" / "Remote" is switched from the perspective of the buyer. #8

Open
kiwiidb opened this issue Nov 16, 2021 · 3 comments
Open

Comments

@kiwiidb
Copy link

kiwiidb commented Nov 16, 2021

Hey there, just bought a channel on testnet using this API.

It seems like local_balance and remote_balance should be switched: right now it's from the perspective of the server, it makes more sense to have it from the POV of the client IMO.

@Jasonvdb
Copy link
Collaborator

Hey, yeah this makes sense. We'll probably update this server side and post back here once done. Thanks!

@john-zaprite
Copy link

Did this change get implemented yet?
Seems like local_balance refers to Synonym's node. Is this expected to change, or should we assume it will stay as-is?

@rbndg
Copy link
Contributor

rbndg commented Apr 27, 2022

we will change it eventually, most likely we will use spending and receiving as the words

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants