Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot set properties of undefined (setting 'inTable') #34

Closed
4 tasks done
capaj opened this issue Sep 20, 2023 · 4 comments
Closed
4 tasks done
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@capaj
Copy link

capaj commented Sep 20, 2023

Initial checklist

Affected packages and versions

2.0.0

Link to runnable example

No response

Steps to reproduce

  1. checkout https://github.com/capaj/authier-pm-web/tree/bump-deps-oct-2023
  2. run pnpm dev
  3. navigate to http://localhost:5450/features

Expected behavior

Does not crash on type error on this MD: https://github.com/capaj/authier-pm-web/blob/bump-deps-oct-2023/pages/features.md

Actual behavior

Uncaught TypeError: Cannot set properties of undefined (setting 'inTable')
    at Object.enterTable (index.js:78:1)
    at compile (index.js:363:1)
    at fromMarkdown (index.js:193:1)
    at parser (index.js:18:24)
    at Function.parse (index.js:273:1)
    at ReactMarkdown (react-markdown.js:106:1)
    at renderWithHooks (react-dom.development.js:16305:1)
    at mountIndeterminateComponent (react-dom.development.js:20074:1)
    at beginWork (react-dom.development.js:21587:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:4164:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:4213:1)
    at invokeGuardedCallback (react-dom.development.js:4277:1)
    at beginWork$1 (react-dom.development.js:27451:1)
    at performUnitOfWork (react-dom.development.js:26557:1)
    at workLoopSync (react-dom.development.js:26466:1)
    at renderRootSync (react-dom.development.js:26434:1)
    at recoverFromConcurrentError (react-dom.development.js:25850:1)
    at performConcurrentWorkOnRoot (react-dom.development.js:25750:1)
    at workLoop (scheduler.development.js:266:1)
    at flushWork (scheduler.development.js:239:1)
    at MessagePort.performWorkUntilDeadline (scheduler.development.js:533:1)

Affected runtime and version

node 18

Affected package manager and version

pnpm

Affected OS and version

ubuntu 22.04

Build and bundle tools

Next.js

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 20, 2023
@ChristianMurphy
Copy link
Member

Duplicate of remarkjs/remark-gfm#57

@ChristianMurphy ChristianMurphy marked this as a duplicate of remarkjs/remark-gfm#57 Sep 20, 2023
@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

@ChristianMurphy
Copy link
Member

A major version release is rolling out across all: mdx, unified, remark, rehype, and micromark packages.
This includes both type changes (static analysis error) and changes to the parser (potential runtime error) if the major versions are mismatched.

Hold on version 3 of remark-gfm, until the next major of react markdown is released

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants