Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: export internal function for extension developer #35

Closed
4 tasks done
ylc395 opened this issue Oct 3, 2023 · 4 comments
Closed
4 tasks done

Feature Request: export internal function for extension developer #35

ylc395 opened this issue Oct 3, 2023 · 4 comments
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Comments

@ylc395
Copy link

ylc395 commented Oct 3, 2023

Initial checklist

Problem

Some internal functions like enter / exit can be reused by developers when developing extensions. Shall we export them? I have to copy and paste them in my codebase for my own extension now.

Solution

export them

Alternatives

none
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 3, 2023
@wooorm
Copy link
Member

wooorm commented Oct 3, 2023

They are exposed through this; I don’t think you ned to copy/paste them.
I also made ±10 extensions, which don’t need that. So I doubt you need to copy/paste them.
If you do, please explain or show your code for why

@wooorm wooorm added the 🙉 open/needs-info This needs some more info label Oct 3, 2023
@github-actions

This comment has been minimized.

Sign in to view
@ylc395
Copy link
Author

ylc395 commented Oct 3, 2023

They are exported in context. Sorry for my rash issue 🙏

@ylc395 ylc395 closed this as completed Oct 3, 2023
@github-actions

This comment was marked as resolved.

Sign in to view
@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Oct 3, 2023
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually 🙉 open/needs-info This needs some more info labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wooorm @ylc395