Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename node types #6

Closed
wooorm opened this issue Mar 8, 2020 · 1 comment
Closed

Rename node types #6

wooorm opened this issue Mar 8, 2020 · 1 comment
Labels
👎 phase/no Post cannot or will not be acted on 🦋 type/enhancement This is great to have

Comments

@wooorm
Copy link
Member

wooorm commented Mar 8, 2020

Subject of the feature

Rest of unified uses lowercase, suffixless values. RootNode -> root. Would make sense to align them.

Actual behaviour

ParagraphNode

Expected behaviour

paragraph

Alternatives

Keep it as it is, it’s been a while, changing it would lead to a bit of confusion for a while too.
@wooorm wooorm mentioned this issue Feb 15, 2021
Closed
27 tasks
@wooorm wooorm added 🙉 open/needs-info This needs some more info and removed 🔍 status/open labels Apr 12, 2021
@wooorm wooorm added the 🤞 phase/open Post is being triaged manually label Aug 22, 2021
@wooorm
Copy link
Member Author

wooorm commented Oct 27, 2022

Closing for now. It isn’t perfect. At some point it can be improved. For now, it might just wrak havoc...

@wooorm wooorm closed this as completed Oct 27, 2022
@wooorm wooorm added the 👎 phase/no Post cannot or will not be acted on label Oct 27, 2022
@github-actions github-actions bot removed 🤞 phase/open Post is being triaged manually 🙉 open/needs-info This needs some more info labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👎 phase/no Post cannot or will not be acted on 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wooorm