Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in protocol 9 documentation in Timer example #299

Closed
synthead opened this issue Jul 6, 2023 · 0 comments · Fixed by #300
Closed

Inconsistency in protocol 9 documentation in Timer example #299

synthead opened this issue Jul 6, 2023 · 0 comments · Fixed by #300
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation protocol 9 Specific to protocol 9

Comments

@synthead
Copy link
Owner

synthead commented Jul 6, 2023

The fourth Timer example in the protocol 9 documentation graphic shows 0:30, but the fourth Timer model in the code example shows 1:30:

Timers

image

TimexDatalinkClient::Protocol9::Timer.new(
  number: 1,
  label: "TIMER 1",
  time: Time.new(0, 1, 1, 0, 5, 0),  # Year, month, and day is ignored.
  action_at_end: :stop_timer
)

TimexDatalinkClient::Protocol9::Timer.new(
  number: 2,
  label: "TIMER 2",
  time: Time.new(0, 1, 1, 0, 10, 0),  # Year, month, and day is ignored.
  action_at_end: :repeat_timer
)

TimexDatalinkClient::Protocol9::Timer.new(
  number: 3,
  label: "TIMER 3",
  time: Time.new(0, 1, 1, 0, 15, 0),  # Year, month, and day is ignored.
  action_at_end: :repeat_timer
)

TimexDatalinkClient::Protocol9::Timer.new(
  number: 4,
  label: "TIMER 4",
  time: Time.new(0, 1, 1, 1, 30, 0),  # Year, month, and day is ignored.
  action_at_end: :stop_timer
)

TimexDatalinkClient::Protocol9::Timer.new(
  number: 5,
  label: "TIMER 5",
  time: Time.new(0, 1, 1, 1, 0, 0),  # Year, month, and day is ignored.
  action_at_end: :start_chrono
)
@synthead synthead added bug Something isn't working documentation Improvements or additions to documentation labels Jul 6, 2023
@synthead synthead self-assigned this Jul 6, 2023
@synthead synthead added the protocol 9 Specific to protocol 9 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation protocol 9 Specific to protocol 9
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant