Skip to content

Commit

Permalink
Merge pull request #21 from synthicity/lcm-added-rows
Browse files Browse the repository at this point in the history
Return indexes of added rows from TransitionModel.transition.
  • Loading branch information
jiffyclub committed May 14, 2014
2 parents 592e64c + 6d6a4a0 commit 22312d1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 4 additions & 1 deletion urbansim/models/tests/test_transition.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,14 @@ def test_transition_model(basic_df, grow_targets_filters, totals_col, year):
{'z': ['a', 'b', 'c', 'd', 'e'],
'thing_id': basic_df.index})

new, new_linked = model.transition(
new, added, new_linked = model.transition(
basic_df, year, linked_tables={'linked': (linked_table, 'thing_id')})

assert len(new) == grow_targets_filters[totals_col].sum()
assert new.index.values.max() == basic_df.index.values.max() + 1
assert len(new_linked['linked']) == grow_targets_filters[totals_col].sum()
assert new.index.values.max() in new_linked['linked'].thing_id.values
assert new_linked['linked'].index.values.max() == 5
assert added.isin(new.index).all()
assert not added.isin(basic_df.index).any()
npt.assert_array_equal(added.values, [basic_df.index.values.max() + 1])
4 changes: 3 additions & 1 deletion urbansim/models/transition.py
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,8 @@ def transition(self, data, year, linked_tables=None):
-------
updated : pandas.DataFrame
Table with rows removed or added.
added : pandas.Series
Indexes of new rows in `updated`.
updated_links : dict of pandas.DataFrame
"""
Expand All @@ -456,4 +458,4 @@ def transition(self, data, year, linked_tables=None):
updated_links[table_name] = \
_update_linked_table(table, col, added, copied, removed)

return updated, updated_links
return updated, added, updated_links

0 comments on commit 22312d1

Please sign in to comment.