Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation report #13

Merged
merged 3 commits into from
Mar 25, 2014
Merged

Simulation report #13

merged 3 commits into from
Mar 25, 2014

Conversation

gonzalobenegas
Copy link
Contributor

No description provided.

@fscottfoti
Copy link
Contributor

Matt this merge looks ok to me, but the build is failing. Is that to be expected? Do you want to take a look at this and then go ahead and merge?

@jiffyclub
Copy link
Member

Builds are passing at the moment, so if Travis reports a failure something is wrong. In this case it was PEP8 formatting issues. I've fixed them here, but in the future Python code should follow PEP8 guidelines: http://legacy.python.org/dev/peps/pep-0008/.

You can use a command line tool like pep8 to check for formatting issues before before committing. (I have the Travis PEP8 checks configured with a maximum line length of 100 characters, but lines over 79 characters should be rare.)

jiffyclub added a commit that referenced this pull request Mar 25, 2014
@jiffyclub jiffyclub merged commit 7946467 into master Mar 25, 2014
@jiffyclub jiffyclub deleted the simulation-report branch March 25, 2014 20:10
@gonzalobenegas
Copy link
Contributor Author

I'll definitely use pep8 next time, thanks.

On 25/03/14 17:09, Matt Davis wrote:

Builds are passing at the moment, so if Travis reports a failure
something is wrong. In this case it was PEP8 formatting issues. I've
fixed them here, but in the future Python code should follow PEP8
guidelines: http://legacy.python.org/dev/peps/pep-0008/.

You can use a command line tool like pep8
http://pep8.readthedocs.org/en/latest/ to check for formatting
issues before before committing. (I have the Travis PEP8 checks
configured with a maximum line length of 100 characters, but lines
over 79 characters should be rare.)


Reply to this email directly or view it on GitHub
#13 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants