Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing dataset and yamlmodelrunner #79

Merged
merged 2 commits into from
Aug 8, 2014
Merged

Conversation

fscottfoti
Copy link
Contributor

just prepping for when we can merge this in!

just prepping for when we can merge this in!
@coveralls
Copy link

Coverage Status

Coverage increased (+6.9%) when pulling 10f279c on remove-dataset-mdlrunner into d0aa343 on master.

@jiffyclub
Copy link
Member

Woot that coverage number is creeping up!

@fscottfoti
Copy link
Contributor Author

Yeah, I started the branch cause I just had to see how we're doing. The
thing is - pmat.py is 120 lines of code that will never be tested because
it uses the GPU and I'm guessing travis couldn't possibly have CUDA
support. So I think maybe we should remove that from the coveralls config
or is that cheating?? And polishing and testing networks.py is high on my
list.

On Wed, Jul 30, 2014 at 7:28 PM, Matt Davis notifications@github.com
wrote:

Woot that coverage number is creeping up!


Reply to this email directly or view it on GitHub
#79 (comment).

@jiffyclub
Copy link
Member

Yeah we can skip pmat.py.

@jiffyclub
Copy link
Member

Done in cc8b207.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.59%) when pulling 7c1ddaa on remove-dataset-mdlrunner into cea8f08 on master.

@fscottfoti
Copy link
Contributor Author

Green!

@waddell
Copy link
Member

waddell commented Aug 6, 2014

Break out the champagne! Well done.

On Tue, Aug 5, 2014 at 11:24 PM, Fletcher Foti notifications@github.com
wrote:

Green!


Reply to this email directly or view it on GitHub
#79 (comment).

fscottfoti added a commit that referenced this pull request Aug 8, 2014
@fscottfoti fscottfoti merged commit b971f2f into master Aug 8, 2014
@fscottfoti fscottfoti deleted the remove-dataset-mdlrunner branch August 8, 2014 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants