Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #312 - Remove Lexer from public API #317

Merged
merged 1 commit into from Sep 14, 2020
Merged

Close #312 - Remove Lexer from public API #317

merged 1 commit into from Sep 14, 2020

Conversation

sys27
Copy link
Owner

@sys27 sys27 commented Sep 13, 2020

No description provided.

@sys27 sys27 added this to the xFunc 4.0.0 milestone Sep 13, 2020
@sys27 sys27 self-assigned this Sep 13, 2020
@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #317 into dev will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #317      +/-   ##
==========================================
+ Coverage   98.07%   98.17%   +0.09%     
==========================================
  Files         164      165       +1     
  Lines        5964     5903      -61     
==========================================
- Hits         5849     5795      -54     
+ Misses        115      108       -7     
Impacted Files Coverage Δ
xFunc.Maths/Tokenization/Tokens/NumberToken.cs 100.00% <ø> (ø)
xFunc.Maths/Tokenization/Tokens/SymbolToken.cs 100.00% <ø> (ø)
xFunc.Maths/Helpers.cs 90.38% <100.00%> (+1.92%) ⬆️
xFunc.Maths/Parser.TokenReader.cs 100.00% <100.00%> (+7.69%) ⬆️
xFunc.Maths/Parser.cs 100.00% <100.00%> (ø)
xFunc.Maths/Processor.cs 92.18% <100.00%> (+1.14%) ⬆️
xFunc.Maths/Tokenization/Lexer.IdToken.cs 100.00% <100.00%> (ø)
xFunc.Maths/Tokenization/Lexer.NumberToken.cs 100.00% <100.00%> (ø)
xFunc.Maths/Tokenization/Lexer.OperatorToken.cs 100.00% <100.00%> (ø)
xFunc.Maths/Tokenization/Lexer.SymbolToken.cs 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2178e...ce8750a. Read the comment docs.

@sys27 sys27 force-pushed the feature/lexer branch 3 times, most recently from 5a75ae8 to 514c3c2 Compare September 13, 2020 09:38
@sys27 sys27 linked an issue Sep 13, 2020 that may be closed by this pull request
4 tasks
@sys27 sys27 force-pushed the feature/lexer branch 2 times, most recently from a08e4dc to 074c6e4 Compare September 13, 2020 16:00
@sys27 sys27 marked this pull request as ready for review September 14, 2020 18:52
@sys27 sys27 merged commit 48c5e09 into dev Sep 14, 2020
@sys27 sys27 deleted the feature/lexer branch September 14, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Lexer from public API
1 participant