馃尡Add checks in ValidCreate and ValidUpdate in hbmmt webhook #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrs147
changed the title
janiskemper
reviewed
May 22, 2024
janiskemper
requested changes
May 23, 2024
janiskemper
reviewed
May 23, 2024
janiskemper
requested changes
May 23, 2024
|
removed it |
janiskemper
reviewed
May 23, 2024
yrs147
force-pushed
the
yrs/webook-provider-machine-template
branch
from
241c620
to
1e32559
Compare
syself-bot
bot
added
area/code
janiskemper
reviewed
Jun 6, 2024
Added validation checks for hbmm , hbmmt , hcloudmachine and hcloud machinetemplate webhooks . Also added the unit tests for the same
yrs147
force-pushed
the
yrs/webook-provider-machine-template
branch
from
25ccb55
to
180a275
Compare
syself-bot
bot
added
the
size/XL
janiskemper
requested changes
Jun 17, 2024
| }) | ||
| It("should validate update", func() { | ||
| newhbmmt := hbmmt.DeepCopy() | ||
| warnings, err := hbmmtwebhook.ValidateUpdate(ctx, oldhbmmt, newhbmmt) |
There was a problem hiding this comment.
I think this test doesn't make sense. oldhbmmt is always nil!
| @@ -247,5 +247,59 @@ var _ = Describe("HCloudMachineTemplateReconciler", func() { | |||
| }, timeout, time.Second).Should(BeTrue()) | |||
| }) | |||
| }) | |||
| Context("HCloudMachineTemplate Webhook Validation", func() { | |||
There was a problem hiding this comment.
the tests here should work with envtest. This means that you create an object and depending on whether you want it to succeed or fail, you expect an error on creation or not. Same with update. For update, you need to first create it, then fetch it, then update it, and expect either an error or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1165
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: