-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Drag and drop steps #146
Comments
I guess steps is a custom field of We can definitely make lists sortable via drag and drop in the UI. I think the sorting better fits into the main editing pane, because
|
You could implement it so that you can only sort it if it's locked to you. For example, have the user click the finding in the left side. Then it will lock and they can rearrange as desired. Also, you could make it so double-clicking a finding in the left will un-nest steps. That way it isn't always cluttered. It could also be an expanding tray that opens to the right so the findings don't jump around on you and both panes are visible. |
Only being able to sort fields while having selected a finding might be annoying when you want to sort of other/multiple findings. The finding list items are already quite densely filled with information (title, severity color, status, assignee, lock), so I would prefer not to add and additional expand icon. Double clicking would be a hidden features that you don't see in the UI, i.e. you have to know that it exists in order to use it. The preferable solution, that integrates best into the current structure and functionality of SysReptor, is sorting in the main panel. It is also easier to handle edge cases like nested lists and makes it clear that you cannot move items between findings. |
Skew the scale for a minute. Pretend you have a finding (or phase) with 10 steps that have 1000 lines each as well as pictures. How would you suggest we drag and drop? If we do it like that, you could implement something like... When we grab a step in the main editor UI, each step collapses into the step name. Otherwise you run into the slow/fast elevator problem. |
Also, apparently I'm the king of finding edge cases. Like the OSDA KQL template, apropos of nothing... |
@GrylledCheez I see you're talking about a concrete design: The OffSec OSDA design. To give a bit of context to other readers: You can use SysReptor to do reporting for certifications. I get your point that drag and drop is not the best solution, because of the height of this element. Drag & Drop makes more sense there. The "steps" case, however, is rather an edge case and exists due to the format of the OSDA report. (e.g. many reports contain a list of strings for "affected targets" and a list of strings for "resources") How would you now define...
For most lists, it does not make sense to appear there. I still see however the point that drag&drop is difficult in this specific case. |
What if the grab bar collapsed each object with the step name being visible? |
We need a generic solution for this. |
Could it be the first line of text in the first text box per element? |
Implemented in https://github.com/Syslifters/sysreptor/releases/tag/2023.145 For small fields (string, enum, date, CVSS, etc.) drag-and-drop is used for sorting. For large fields (markdown, object, nested list) move-up and move-down buttons are available. |
Sometimes when making a report, I need to re-order the steps because either I put them in wrong, or I discovered something new that needs to be inserted. It would be nice to simply drag and drop them in at least 2 different ways.
The text was updated successfully, but these errors were encountered: