Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket Issue #256

Closed
carter-falconops opened this issue May 21, 2024 · 2 comments
Closed

Websocket Issue #256

carter-falconops opened this issue May 21, 2024 · 2 comments

Comments

@carter-falconops
Copy link

Hello,

I recently updated my instance to 2024.40 from 2024.30 and noticed that I am constantly getting the HTTP fallback message due to the client not being able to connect to the websocket. This was not an issue for my deployment on 2024.30 and the websockets worked fine.

I am using the suggested nginx config and have not changed anything in my configuration from 2024.30 -> 2024.40. All of the errors in the chrome dev console are reporting from this line

websocket.value = new WebSocket(wsUrl);

The error specifically says 'Failed to establish connection' however I have confirmed that the websocket is open via websocat. Any advice on what I may be doing wrong?

@aronmolnar
Copy link
Contributor

Hi Carter,

It is probably due to the fix for a security vulnerability we have had since the introduction of WebSockets (see https://github.com/Syslifters/sysreptor/security/advisories).
It can probably be fixed if you configure the ALLOWED_HOSTS in your app.env (https://docs.sysreptor.com/setup/configuration/#allowed-hosts).

@carter-falconops
Copy link
Author

That was it! Thank you, I appreciate the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants