compiling with redis support on FreeBSD fails

[czanik]

tested on FreeBSD 10.1 amd64 with syslog-ng 3.6.2

If support for redis is enabled, compilation fails with the following error message:

CC modules/redis/modules_redis_libredis_la-redis-grammar.lo
CC modules/redis/modules_redis_libredis_la-redis.lo
CC modules/redis/modules_redis_libredis_la-redis-parser.lo
CCLD modules/redis/libredis.la
libtool: link: require no space between -L' and-lhiredis'
Makefile:5165: recipe for target 'modules/redis/libredis.la' failed
gmake[4]: *** [modules/redis/libredis.la] Error 1
Makefile:9846: recipe for target 'all-recursive' failed
gmake[3]: *** [all-recursive] Error 1
Makefile:4042: recipe for target 'all' failed
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory '/usr/ports/sysutils/syslog-ng/work/syslog-ng-3.6.2'
*** Error code 1

[ihrwein]

What are your configure options?

[czanik]

It's generated by FreeBSD ports (/usr/ports/sysutils/syslog-ng):
'''
--sysconfdir=/usr/local/etc --localstatedir=/var/db --enable-dynamic-linking --enable-debug --datadir=/usr/local/share/syslog-ng/ --enable-ssl --enable-tcp-wrapper --enable-spoof-source --with-libnet=/usr/local/bin --enable-ipv6 --enable-geoip --enable-redis --with-libesmtp=/usr/local/ --enable-sql --enable-json --disable-linux-caps --prefix=/usr/local
'''

[algernon]

Better yet, the tail of make output with make V=1 would be even more useful, so we see the commandline that fails, not just a prettier CCLD text.

[czanik]

libtool: link: ( cd "modules/afstomp/.libs" && rm -f "libafstomp.la" && ln -s "../libafstomp.la" "libafstomp.la" )
/bin/sh ./libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I./lib -I./modules -I./lib -I./modules -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/eventlog -I/usr/local/include -I/usr/local/include -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DHAVE_SOCKADDR_SA_LEN -I/usr/local/include/dbi -I/usr/local/include/dbi/dbi -I./lib/ivykis/src/include -I./lib/ivykis/src/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I -D_FILE_OFFSET_BITS=64 -I./modules/redis -I./modules/redis -O2 -pipe -I/usr/local/include/libnet11 -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wall -g -pthread -MT modules/redis/modules_redis_libredis_la-redis-grammar.lo -MD -MP -MF modules/redis/.deps/modules_redis_libredis_la-redis-grammar.Tpo -c -o modules/redis/modules_redis_libredis_la-redis-grammar.lo test -f 'modules/redis/redis-grammar.c' || echo './'modules/redis/redis-grammar.c
libtool: compile: cc -DHAVE_CONFIG_H -I. -I./lib -I./modules -I./lib -I./modules -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/eventlog -I/usr/local/include -I/usr/local/include -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DHAVE_SOCKADDR_SA_LEN -I/usr/local/include/dbi -I/usr/local/include/dbi/dbi -I./lib/ivykis/src/include -I./lib/ivykis/src/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I -D_FILE_OFFSET_BITS=64 -I./modules/redis -I./modules/redis -O2 -pipe -I/usr/local/include/libnet11 -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wall -g -pthread -MT modules/redis/modules_redis_libredis_la-redis-grammar.lo -MD -MP -MF modules/redis/.deps/modules_redis_libredis_la-redis-grammar.Tpo -c modules/redis/redis-grammar.c -fPIC -DPIC -o modules/redis/.libs/modules_redis_libredis_la-redis-grammar.o
mv -f modules/redis/.deps/modules_redis_libredis_la-redis-grammar.Tpo modules/redis/.deps/modules_redis_libredis_la-redis-grammar.Plo
/bin/sh ./libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I./lib -I./modules -I./lib -I./modules -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/eventlog -I/usr/local/include -I/usr/local/include -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DHAVE_SOCKADDR_SA_LEN -I/usr/local/include/dbi -I/usr/local/include/dbi/dbi -I./lib/ivykis/src/include -I./lib/ivykis/src/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I -D_FILE_OFFSET_BITS=64 -I./modules/redis -I./modules/redis -O2 -pipe -I/usr/local/include/libnet11 -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wall -g -pthread -MT modules/redis/modules_redis_libredis_la-redis.lo -MD -MP -MF modules/redis/.deps/modules_redis_libredis_la-redis.Tpo -c -o modules/redis/modules_redis_libredis_la-redis.lo test -f 'modules/redis/redis.c' || echo './'modules/redis/redis.c
libtool: compile: cc -DHAVE_CONFIG_H -I. -I./lib -I./modules -I./lib -I./modules -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/eventlog -I/usr/local/include -I/usr/local/include -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DHAVE_SOCKADDR_SA_LEN -I/usr/local/include/dbi -I/usr/local/include/dbi/dbi -I./lib/ivykis/src/include -I./lib/ivykis/src/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I -D_FILE_OFFSET_BITS=64 -I./modules/redis -I./modules/redis -O2 -pipe -I/usr/local/include/libnet11 -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wall -g -pthread -MT modules/redis/modules_redis_libredis_la-redis.lo -MD -MP -MF modules/redis/.deps/modules_redis_libredis_la-redis.Tpo -c modules/redis/redis.c -fPIC -DPIC -o modules/redis/.libs/modules_redis_libredis_la-redis.o
mv -f modules/redis/.deps/modules_redis_libredis_la-redis.Tpo modules/redis/.deps/modules_redis_libredis_la-redis.Plo
/bin/sh ./libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I./lib -I./modules -I./lib -I./modules -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/eventlog -I/usr/local/include -I/usr/local/include -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DHAVE_SOCKADDR_SA_LEN -I/usr/local/include/dbi -I/usr/local/include/dbi/dbi -I./lib/ivykis/src/include -I./lib/ivykis/src/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I -D_FILE_OFFSET_BITS=64 -I./modules/redis -I./modules/redis -O2 -pipe -I/usr/local/include/libnet11 -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wall -g -pthread -MT modules/redis/modules_redis_libredis_la-redis-parser.lo -MD -MP -MF modules/redis/.deps/modules_redis_libredis_la-redis-parser.Tpo -c -o modules/redis/modules_redis_libredis_la-redis-parser.lo test -f 'modules/redis/redis-parser.c' || echo './'modules/redis/redis-parser.c
libtool: compile: cc -DHAVE_CONFIG_H -I. -I./lib -I./modules -I./lib -I./modules -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/eventlog -I/usr/local/include -I/usr/local/include -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DHAVE_SOCKADDR_SA_LEN -I/usr/local/include/dbi -I/usr/local/include/dbi/dbi -I./lib/ivykis/src/include -I./lib/ivykis/src/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I -D_FILE_OFFSET_BITS=64 -I./modules/redis -I./modules/redis -O2 -pipe -I/usr/local/include/libnet11 -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wall -g -pthread -MT modules/redis/modules_redis_libredis_la-redis-parser.lo -MD -MP -MF modules/redis/.deps/modules_redis_libredis_la-redis-parser.Tpo -c modules/redis/redis-parser.c -fPIC -DPIC -o modules/redis/.libs/modules_redis_libredis_la-redis-parser.o
mv -f modules/redis/.deps/modules_redis_libredis_la-redis-parser.Tpo modules/redis/.deps/modules_redis_libredis_la-redis-parser.Plo
/bin/sh ./libtool --tag=CC --mode=link cc -I -D_FILE_OFFSET_BITS=64 -I./modules/redis -I./modules/redis -O2 -pipe -I/usr/local/include/libnet11 -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wall -g -pthread -avoid-version -module -no-undefined -L/usr/local/lib/libnet11 -lnet -L/usr/local/lib -Wl,-rpath,/usr/local/lib -fstack-protector -o modules/redis/libredis.la -rpath /usr/local/lib/syslog-ng modules/redis/modules_redis_libredis_la-redis-grammar.lo modules/redis/modules_redis_libredis_la-redis.lo modules/redis/modules_redis_libredis_la-redis-parser.lo -L -lhiredis ./lib/libsyslog-ng.la
libtool: link: require no space between -L' and-lhiredis'
Makefile:5165: recipe for target 'modules/redis/libredis.la' failed
gmake[4]: *** [modules/redis/libredis.la] Error 1
Makefile:9846: recipe for target 'all-recursive' failed
gmake[3]: *** [all-recursive] Error 1
Makefile:4042: recipe for target 'all' failed
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory '/usr/ports/sysutils/syslog-ng/work/syslog-ng-3.6.2'
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/sysutils/syslog-ng
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/syslog-ng

[algernon]

There's a stray -L there, and that upsets the compiler. Can you check the output of pkg-config --libs hiredis? (And if that fails, then pkg-config --libs libhiredis)

[czanik]

root@fb101r:/usr/ports/sysutils/syslog-ng # pkg-config --libs hiredis
-L -lhiredis

[algernon]

That's the problem then. The pkg-config file of hiredis has an empty -L. The issue is best fixed there, I believe, rather than adding hackish workarounds to our configure script.

[cschuber]

A patch has been committed.

[ihrwein]

@czanik @cschuber: Please verify and close this issue.

[czanik]

@cschuber commited a workaround to FreeBSD ports and now it works fine.