Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 'SetParser::parse1', variable tracking and 'handler_special_queries' #3317

Closed
2 tasks done
JavierJF opened this issue Feb 24, 2021 · 1 comment
Closed
2 tasks done

Comments

@JavierJF
Copy link
Collaborator

  • A clear description of the issue
  1. Right now there are multiple ways of making the Regex present in 'SetParser::parse1' fail, the original query that triggered this error was:

    SET sql_mode=(SELECT CONCAT(@@sql_mode, ',PIPES_AS_CONCAT,NO_ENGINE_SUBSTITUTION')), inexisting_variable = '+00:00', incorrect_NAMES utf8mb4 COLLATE utf8mb4_unicode_ci;
    

    When executed, ProxySQL will execute an SET sql_mode='' on the backend connection.

  2. When part of a SET statement with multiple values fails to be parsed, ProxySQL should try to keep track of the rest of variables tried to be set in it, and then fail.

  3. ProxySQL should take into account when locking into a hostgroup has occur for several queries handled by 'handler_special_queries'. Right now this is not the case, preventing the correct execution of several 'SET' statements when locked into a hostgroup.

  • ProxySQL version

v2.0.18
v2.1.1

@JavierJF
Copy link
Collaborator Author

Closed by #3318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant