Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text isn't using default variant without passing a variant prop. #1024

Closed
pkrawc opened this issue Jun 22, 2020 · 5 comments
Closed

Text isn't using default variant without passing a variant prop. #1024

pkrawc opened this issue Jun 22, 2020 · 5 comments

Comments

@pkrawc
Copy link

pkrawc commented Jun 22, 2020

Description

According to the docs the <Text/> component should use the text.default variant automatically, when implemented with next it does not inherit the default value.

Screens

Screen Shot 2020-06-22 at 4 42 28 PM
In the bottom section, the card on the left is explicitly declaring variant: default and the card next to it isn't. Both are using the <Text/> component from theme-ui

@pkrawc
Copy link
Author

pkrawc commented Jun 22, 2020

It's because the update to the Text component hasn't landed in a stable release yet.

The docs probably shouldn't dictate something that isn't in the default branch.

@cameronwlewis
Copy link

Just discovered this as well. Glad I found this issue, since I've been fruitlessly trying to solve this over the last hour. Thanks for posting @pkrawc . Guess I'll resort to putting in text.default variant manually for now.

@pkrawc
Copy link
Author

pkrawc commented Jun 23, 2020

@cameronwlewis and whomever else finds this until close. You can solve the issue by upgrading your package to theme-ui@next

@dandenney
Copy link

@pkrawc Thank you so much for the @next tip!

@lachlanjc
Copy link
Member

@hasparus I’m cool to close since this is merged & on a published release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants