Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fix preset page demo text color #1115

Merged
merged 2 commits into from Sep 1, 2020

Conversation

lachlanjc
Copy link
Member

@lachlanjc lachlanjc commented Aug 10, 2020

Closes #808

New behavior:

Base Others
2226C9CB-23AD-4EA2-B1EB-05921385FF00 6639BFE0-F47C-4A35-8C34-EACDBF75FC26
9E1CB6D6-6398-43C6-9776-BD4C859422C1 6060383C-8E84-48F9-BA13-93DD727972B1

@hasparus
Copy link
Member

Nice one! This fixes #808!

I just noticed that my issue description was written in super confusing way BTW 😅

@lachlanjc
Copy link
Member Author

You’re good, I’d seen the bug too! This isn’t the prettiest solution visually but I think it’s the only answer that always works & makes sense—otherwise we’re stripping parts of the theme you’re previewing out to integrate with the site’s theme.

@hasparus
Copy link
Member

Yeah, maybe some padding would help to make it more visually pleasing... Okay, I really doubt we can do correct and visually pleasing both in this case.

I wondered if the select shouldn't change the entire theme of the docs, but the themes in showcase may actually be not compatible with each other and the docs, so the solution you have right now is better.

@lachlanjc
Copy link
Member Author

Went back & forth but wanted to keep the changes minimal. Implemented:

61ED297D-FEAC-4185-8E2E-90E82A490009
7EE87450-810A-4F20-89FF-E9766646D4C9

@hasparus hasparus requested a review from jxnblk August 12, 2020 08:05
@jxnblk
Copy link
Member

jxnblk commented Sep 1, 2020

Awesome, thanks!

@jxnblk jxnblk merged commit d4d9dda into system-ui:master Sep 1, 2020
@lachlanjc lachlanjc deleted the fix-808 branch September 1, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(docs) text in /demo (lorem.mdx) doesn't take color from the theme
3 participants