Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate package @emotion/is-prop-valid through styled-system dependency #1420

Closed
okonet opened this issue Jan 7, 2021 · 1 comment · Fixed by #2043
Closed

Duplicate package @emotion/is-prop-valid through styled-system dependency #1420

okonet opened this issue Jan 7, 2021 · 1 comment · Fixed by #2043
Assignees
Labels
bug Something isn't working

Comments

@okonet
Copy link

okonet commented Jan 7, 2021

Describe the bug

When using DuplicatePackageCheckerPlugin with the latest version 0.6.0-alpha.4 and "@emotion/react": "^11.1.4" and "@emotion/styled": "^11.0.0" I'm seeing:

warn  - @emotion/is-prop-valid
  Multiple versions of @emotion/is-prop-valid found:
    0.8.8 ./~/@emotion/is-prop-valid
    1.0.0 ./~/@emotion/styled/~/@emotion/is-prop-valid

To Reproduce

Add https://github.com/darrenscerri/duplicate-package-checker-webpack-plugin to the project using Theme UI and try building.

Expected behavior

No duplicated packages should be added to the bundle.

Additional context

➜ npx npm-why @emotion/is-prop-valid

  Who required @emotion/is-prop-valid:

  monolisa-website > theme-ui > @theme-ui/components > @styled-system/should-forward-prop > @emotion/is-prop-valid@0.8.8

so it looks like it's coming from styled-system which is a dependency of Theme UI and probably needs to be updated there.

@hasparus hasparus self-assigned this Jan 7, 2021
@hasparus hasparus added the bug Something isn't working label Jan 7, 2021
@hasparus
Copy link
Member

hasparus commented Jan 7, 2021

Thanks for the issue @okonet!
We're planning to drop @styled-system/should-forward-prop dependency pretty soon. I'm glad there's yet another reason to do this :D

@hasparus hasparus changed the title Duplicate package Duplicate package @emotion/is-prop-valid through styled-system dependency Jan 7, 2021
@lachlanjc lachlanjc linked a pull request Jan 7, 2021 that will close this issue
@lachlanjc lachlanjc linked a pull request Jan 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants