Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properties leaking through #1471

Closed
atanasster opened this issue Jan 26, 2021 · 1 comment · Fixed by #2057
Closed

properties leaking through #1471

atanasster opened this issue Jan 26, 2021 · 1 comment · Fixed by #2057
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.

Comments

@atanasster
Copy link
Collaborator

Describe the bug
Object properties are leaking from the pagination component

To Reproduce

  1. go to a page with pagination : https://theme-ui.com/getting-started
  2. Observe the pagination component:

sidebar-props
@hasparus hasparus added the affects-docs Changes affect documentation, but not only documentation label Jan 26, 2021
@lachlanjc lachlanjc added documentation Changes only affect the documentation and removed affects-docs Changes affect documentation, but not only documentation labels Oct 27, 2021
@lachlanjc lachlanjc mentioned this issue Dec 30, 2021
Merged
@hasparus hasparus added the prerelease This change is available in a prerelease. label Jan 15, 2022
@hasparus
Copy link
Member

🚀 Issue was released in v0.14.0 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sidenav: Fix props leaking to DOM on Pagination component system-ui/theme-ui
3 participants
@lachlanjc @atanasster @hasparus