New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding non-markdown elements to Styled
#152
Comments
This idea makes sense to me as I'm using theme-ui for both HTML (landing page) and markdown (blog). Adding all of my base elements to the theme config keeps things nice and tidy without having to look-up which elements markdown doesn't support - or double checking my variants for those extra elements. Then markdown can pick up all of the Is it as simple as updating the |
Yes, but we'll want to still limit which tags we add here since they'll increase the overall bundle size and cannot be tree-shaken |
I see! Forgive me if this is a silly question, but could these extra non-markdown elements be generated by mapping over the |
I guess they could be created based on |
Oh okay that's interesting, in that case is using variants different from creating components during render? (have you got any links where I can read more about this?) As for element suggestions, how about the base form elements: |
There are some docs here, but they certainly could use some work: https://theme-ui.com/guides/variants Variants use the theming context available in the |
Some HTML elements might be expected to exist in the
Styled
components, e.g.Styled.button
, but don't currently. It's probably not harmful to add a few more common elements to the mix.The text was updated successfully, but these errors were encountered: