Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add short section on contributing to README #5

Closed
japhir opened this issue Feb 11, 2022 · 12 comments
Closed

add short section on contributing to README #5

japhir opened this issue Feb 11, 2022 · 12 comments

Comments

@japhir
Copy link
Contributor

japhir commented Feb 11, 2022

as discussed in the stream, would be nice to have a section on how to contribute.

@japhir
Copy link
Contributor Author

japhir commented Feb 11, 2022

or as a separate CONTRIBUTING.(org|md) file

@japhir
Copy link
Contributor Author

japhir commented Feb 11, 2022

@japhir
Copy link
Contributor Author

japhir commented Feb 12, 2022

I wrote a first draft, feel free to give feedback or to improve it :)

@omarcospo
Copy link

Making a pattern of modules would be nice to have everything cohesive, so newcomers know how to create new modules. E.g:

;;; rational-<module-name>.el --- <Little description> -*- lexical-binding: t; -*-

< Start module >

(provide 'rational-<module-name>)

And maybe an org file with the module's documentation.

@daviwil
Copy link
Member

daviwil commented Feb 14, 2022

@mfxarc A section on "Creating new modules" would be nice! Org files for module documentation would also be great, but it'd be nice if we could generate those from the source of the modules so that we wouldn't have to keep things up to date in 2 places.

@ajxn
Copy link
Contributor

ajxn commented Feb 14, 2022

Wouldn't it be better if the pattern was how Emacs (and elisp mode) like to have descriptions in files?

Or even have a yasnippet or something like that added, with this as a snippet?

@daviwil
Copy link
Member

daviwil commented Feb 14, 2022

We should definitely have expanded descriptions in the source files, just haven't gotten to that yet. I think we could add a Skeleton (or some other form of Emacs auto-insert) to create a new file template that can be called up from within this configuration:

https://www.gnu.org/software/emacs/manual/html_node/autotype/Autoinserting.html

@shubham-cpp
Copy link

shubham-cpp commented Feb 14, 2022

The Principles links follows to page not found(In the contributing section)

@japhir
Copy link
Contributor Author

japhir commented Feb 14, 2022

Yeah I noticed this this morning as well. Kind of annoying because it's a valid org link :(

@japhir
Copy link
Contributor Author

japhir commented Feb 14, 2022

Also, the second little elisp-style button isn't working somehow. Perhaps because there's a space (%20) in it?

@japhir
Copy link
Contributor Author

japhir commented Feb 14, 2022

Fixed those two issues in #21 and #22 :) (sometimes using the web interface is quicker)

@daviwil
Copy link
Member

daviwil commented Feb 14, 2022

Thanks @japhir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants