(#1709187) core:scope: fix missing fragment_path #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fragment_path in struct unit is a record of unit file, which will be deleted (unlink) in unit_free(). After a daemon-reload process, the u->fragment_path of scope unit will be missing (NULL). Then, the discarded session scope unit file will be redundant until reboot. Steps to Reproduce problem: 1. ssh access and login 2. systemctl daemon-reload 3. ssh logout 4. discarded session-xxx.scope file will be found in /run/systemd/system/ So in a daemon-reload case, scope_load() need unit_load_fragment() to reload u->fragment_path. (cherry picked from commit f838bf3) Resolves: #1709187
jsynacek
added
tracker/unapproved
systemd-rhel-bot
changed the title
systemd-rhel-bot
added
rhel-7.4
ci-waived
and removed
tracker/unapproved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fragment_path in struct unit is a record of unit file, which will
be deleted (unlink) in unit_free().
After a daemon-reload process, the u->fragment_path of scope unit
will be missing (NULL). Then, the discarded session scope unit file
will be redundant until reboot.
Steps to Reproduce problem:
So in a daemon-reload case, scope_load() need unit_load_fragment() to reload
u->fragment_path.
(cherry picked from commit f838bf3)
Resolves: #1709187