Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1769928) sd-bus: when attached to an sd-event loop, disconnect on processing e #71

Merged

Conversation

msekletar
Copy link
Member

If we can't process the bus for some reason we shouldn't just disable
the event source, but log something and give up on the connection. Hence
do that, and disconnect.

(cherry-picked from commit 5ae37ad)

Resolves: #1769928

…rrors

If we can't process the bus for some reason we shouldn't just disable
the event source, but log something and give up on the connection. Hence
do that, and disconnect.

(cherry-picked from commit 5ae37ad)

Resolves: #1769928
@msekletar msekletar added the tracker/unapproved Formerly needs-acks label Feb 3, 2020
@systemd-rhel-bot systemd-rhel-bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review and removed pr/needs-ci Formerly needs-ci labels Feb 3, 2020
@systemd-rhel-bot systemd-rhel-bot changed the title (#1769928) sd-bus: when attached to an sd-event loop, disconnect on processing e (#1769928) (#1769928) sd-bus: when attached to an sd-event loop, disconnect on processing e Feb 4, 2020
Copy link
Contributor

@jsynacek jsynacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Feb 11, 2020
@dtardon dtardon changed the title (#1769928) (#1769928) sd-bus: when attached to an sd-event loop, disconnect on processing e (#1769928) sd-bus: when attached to an sd-event loop, disconnect on processing e Feb 12, 2020
@systemd-rhel-bot systemd-rhel-bot removed the tracker/unapproved Formerly needs-acks label Mar 26, 2020
@systemd-rhel-bot systemd-rhel-bot merged commit 2462269 into redhat-plumbers:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants